Split _dbus_set_fd_nonblocking vs. _dbus_set_socket_nonblocking

The former is Unix-specific, the latter is also portable to Windows.
On Unix, they're really the same thing.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89444
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>

diff --git a/dbus/dbus-internals.h b/dbus/dbus-internals.h
index 6368538942e890f553f21324fd3be16d42fe5799..225a9b66b1849ed199b282d4ec0c8cb33a5a4754 100644 (file)
--- a/dbus/dbus-internals.h
+++ b/dbus/dbus-internals.h
@@ -279,9 +279,6 @@ char**      _dbus_dup_string_array      (const char **array);
 typedef void (* DBusForeachFunction) (void *element,
                                       void *data);
 
-dbus_bool_t _dbus_set_fd_nonblocking (int             fd,
-                                      DBusError      *error);
-
 void _dbus_verbose_bytes           (const unsigned char *data,
                                     int                  len,
                                     int                  offset);

diff --git a/dbus/dbus-server-socket.c b/dbus/dbus-server-socket.c
index a05e3015b30cca734f8fef78dd3f94baa1847eba..73ddfe3826a60af263cebbceae84937ffedc9e4f 100644 (file)
--- a/dbus/dbus-server-socket.c
+++ b/dbus/dbus-server-socket.c
@@ -95,7 +95,7 @@ handle_new_client_fd_and_unlock (DBusServer *server,
 
   HAVE_LOCK_CHECK (server);
 
-  if (!_dbus_set_fd_nonblocking (client_fd, NULL))
+  if (!_dbus_set_socket_nonblocking (client_fd, NULL))
     {
       SERVER_UNLOCK (server);
       return TRUE;

diff --git a/dbus/dbus-sysdeps-unix.c b/dbus/dbus-sysdeps-unix.c
index bb4724b2a4f21a9945ae03eaea02c6bd0b88e25c..f6121a7a78c7251805df341becc5b8abcc20d756 100644 (file)
--- a/dbus/dbus-sysdeps-unix.c
+++ b/dbus/dbus-sysdeps-unix.c
@@ -134,6 +134,9 @@
 
 #endif /* Solaris */
 
+static dbus_bool_t _dbus_set_fd_nonblocking (int             fd,
+                                             DBusError      *error);
+
 static dbus_bool_t
 _dbus_open_socket (int              *fd_p,
                    int               domain,
@@ -3207,6 +3210,13 @@ _dbus_dup(int        fd,
  * @returns #TRUE on success.
  */
 dbus_bool_t
+_dbus_set_socket_nonblocking (DBusSocket      fd,
+                              DBusError      *error)
+{
+  return _dbus_set_fd_nonblocking (fd, error);
+}
+
+static dbus_bool_t
 _dbus_set_fd_nonblocking (int             fd,
                           DBusError      *error)
 {

diff --git a/dbus/dbus-sysdeps-win.c b/dbus/dbus-sysdeps-win.c
index 48b28b3ae83d488e940b6453c648c8c156666a79..28ec7f04530700ec6aca7338126b4da9fb7d19b0 100644 (file)
--- a/dbus/dbus-sysdeps-win.c
+++ b/dbus/dbus-sysdeps-win.c
@@ -538,8 +538,8 @@ _dbus_win_handle_set_close_on_exec (HANDLE handle)
  * @returns #TRUE on success.
  */
 dbus_bool_t
-_dbus_set_fd_nonblocking (int             handle,
-                          DBusError      *error)
+_dbus_set_socket_nonblocking (DBusSocket      handle,
+                              DBusError      *error)
 {
   u_long one = 1;
 
@@ -1615,7 +1615,7 @@ _dbus_connect_tcp_socket_with_nonce (const char     *host,
   /* Every SOCKET is also a HANDLE. */
   _dbus_win_handle_set_close_on_exec ((HANDLE) fd);
 
-  if (!_dbus_set_fd_nonblocking (fd, error))
+  if (!_dbus_set_socket_nonblocking (fd, error))
     {
       closesocket (fd);
       return -1;
@@ -1824,7 +1824,7 @@ _dbus_listen_tcp_socket (const char     *host,
   for (i = 0 ; i < nlisten_fd ; i++)
     {
       _dbus_win_handle_set_close_on_exec ((HANDLE) listen_fd[i]);
-      if (!_dbus_set_fd_nonblocking (listen_fd[i], error))
+      if (!_dbus_set_socket_nonblocking (listen_fd[i], error))
         {
           goto failed;
         }

diff --git a/dbus/dbus-sysdeps.h b/dbus/dbus-sysdeps.h
index 4c92928b66e284f05446dbcb570200f6ba8b3c92..2a80aa46cc52819b2fd95f3d0c2e1e81e5fc5267 100644 (file)
--- a/dbus/dbus-sysdeps.h
+++ b/dbus/dbus-sysdeps.h
@@ -164,6 +164,9 @@ _dbus_socket_get_invalid (void)
   return s;
 }
 
+dbus_bool_t _dbus_set_socket_nonblocking (DBusSocket      fd,
+                                          DBusError      *error);
+
 DBUS_PRIVATE_EXPORT
 dbus_bool_t _dbus_close_socket     (DBusSocket        fd,
                                     DBusError        *error);
@@ -225,7 +228,6 @@ int _dbus_listen_tcp_socket   (const char     *host,
                                DBusError      *error);
 DBusSocket _dbus_accept       (DBusSocket      listen_fd);
 
-
 dbus_bool_t _dbus_read_credentials_socket (DBusSocket        client_fd,
                                            DBusCredentials  *credentials,
                                            DBusError        *error);