]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
leds: as3645a: Fix error return code in as3645a_parse_node()
authorZhen Lei <thunder.leizhen@huawei.com>
Sat, 15 May 2021 03:06:46 +0000 (11:06 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:15:57 +0000 (16:15 +0200)
[ Upstream commit 96a30960a2c5246c8ffebe8a3c9031f9df094d97 ]

Return error code -ENODEV rather than '0' when the indicator node can not
be found.

Fixes: a56ba8fbcb55 ("media: leds: as3645a: Add LED flash class driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/leds/leds-as3645a.c

index f883616d9e606bffd713261bf8245dd371f97867..821944379f2cf9aceec82d34e9294f92c48219f0 100644 (file)
@@ -565,6 +565,7 @@ static int as3645a_parse_node(struct as3645a *flash,
        if (!flash->indicator_node) {
                dev_warn(&flash->client->dev,
                         "can't find indicator node\n");
+               rval = -ENODEV;
                goto out_err;
        }