]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
checklayer: Really fix regex in get_signatures
authorPaul Barker <paul@pbarker.dev>
Sat, 28 Mar 2026 09:49:58 +0000 (09:49 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 30 Mar 2026 16:51:26 +0000 (17:51 +0100)
The previous attempt to fix the regex in get_signatures was only a
partial success. We should just be comparing unihash values, inclusion
of the taskhash value in our comparison adds no benefit. Inclusion of
the task hash also results in invalid bitbake-diffsigs commands being
recommended if there are conflicting signatures.

Fixes: a2f7052cf832 ("checklayer: Fix regex in get_signatures")
Signed-off-by: Paul Barker <paul@pbarker.dev>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/lib/checklayer/__init__.py

index 15459b6e04865d15f5a4ce2c87ad4d6c6a88cb4b..f9ba44d08d881fd1ef19eabad358e4e11fa5c1ff 100644 (file)
@@ -324,7 +324,7 @@ def get_signatures(builddir, failsafe=False, machine=None, extravars=None):
         else:
             raise
 
-    sig_regex = re.compile(r"^(?P<task>[^:]*:[^:]*):(?P<hash>.*) .$")
+    sig_regex = re.compile(r"^(?P<task>[^:]*:[^:]*)(:(?P<taskhash>[^:]*))?:(?P<hash>.*) .$")
     tune_regex = re.compile(r"(^|\s)SIGGEN_LOCKEDSIGS_t-(?P<tune>\S*)\s*=\s*")
     current_tune = None
     with open(sigs_file, 'r') as f: