]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
hwmon: (cgbc-hwmon) Add missing NULL check after devm_kzalloc()
authorLi Qiang <liqiang01@kylinos.cn>
Fri, 17 Oct 2025 06:34:14 +0000 (14:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2025 13:10:27 +0000 (14:10 +0100)
[ Upstream commit a09a5aa8bf258ddc99a22c30f17fe304b96b5350 ]

The driver allocates memory for sensor data using devm_kzalloc(), but
did not check if the allocation succeeded. In case of memory allocation
failure, dereferencing the NULL pointer would lead to a kernel crash.

Add a NULL pointer check and return -ENOMEM to handle allocation failure
properly.

Signed-off-by: Li Qiang <liqiang01@kylinos.cn>
Fixes: 08ebc9def79fc ("hwmon: Add Congatec Board Controller monitoring driver")
Reviewed-by: Thomas Richard <thomas.richard@bootlin.com>
Link: https://lore.kernel.org/r/20251017063414.1557447-1-liqiang01@kylinos.cn
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/cgbc-hwmon.c

index 772f44d56ccfff58e6a5f24044b6f62a0ffe9ecc..3aff4e092132f64943096c24bce9d63425e7ed4a 100644 (file)
@@ -107,6 +107,9 @@ static int cgbc_hwmon_probe_sensors(struct device *dev, struct cgbc_hwmon_data *
        nb_sensors = data[0];
 
        hwmon->sensors = devm_kzalloc(dev, sizeof(*hwmon->sensors) * nb_sensors, GFP_KERNEL);
+       if (!hwmon->sensors)
+               return -ENOMEM;
+
        sensor = hwmon->sensors;
 
        for (i = 0; i < nb_sensors; i++) {