]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Check return of init_keys() ip_address_changed: fix Coverity CID 484
authorNick Mathewson <nickm@torproject.org>
Thu, 6 Oct 2011 16:59:25 +0000 (12:59 -0400)
committerNick Mathewson <nickm@torproject.org>
Thu, 6 Oct 2011 18:13:09 +0000 (14:13 -0400)
changes/cov484 [new file with mode: 0644]
src/or/main.c

diff --git a/changes/cov484 b/changes/cov484
new file mode 100644 (file)
index 0000000..33adbda
--- /dev/null
@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - Report any failure in init_keys() calls done because our IP address
+      has changed. Spotted by Coverity Scan. Bugfix on 0.1.1.4-alpha;
+      fixes CID 484.
index 289d805503f35811e2a8bb48958abffdee5625d1..c011c9b46ee4b901d63fa3545aba0267cabd2bbf 100644 (file)
@@ -1378,7 +1378,8 @@ ip_address_changed(int at_interface)
   if (at_interface) {
     if (! server) {
       /* Okay, change our keys. */
-      init_keys();
+      if (init_keys()<0)
+        log_warn(LD_GENERAL, "Unable to rotate keys after IP change!");
     }
   } else {
     if (server) {