]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iio: proximity: srf08: Replace sprintf() with sysfs_emit()
authorMaxwell Doose <m32285159@gmail.com>
Wed, 22 Apr 2026 12:45:05 +0000 (07:45 -0500)
committerJonathan Cameron <jic23@kernel.org>
Mon, 27 Apr 2026 08:58:24 +0000 (09:58 +0100)
Replace sprintf() function calls with sysfs_emit() and
sysfs_emit_at(). While the current code is fine, sysfs_emit() is
preferred over sprintf(), and will help modernize the driver.

Signed-off-by: Maxwell Doose <m32285159@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/proximity/srf08.c

index d7e4cc48cfbf700c7828235de99a66324767316a..92a37ba331f6acb53865adb5ee96ef663e6ad1f5 100644 (file)
@@ -226,7 +226,7 @@ static int srf08_read_raw(struct iio_dev *indio_dev,
 static ssize_t srf08_show_range_mm_available(struct device *dev,
                                struct device_attribute *attr, char *buf)
 {
-       return sprintf(buf, "[0.043 0.043 11.008]\n");
+       return sysfs_emit(buf, "[0.043 0.043 11.008]\n");
 }
 
 static IIO_DEVICE_ATTR(sensor_max_range_available, S_IRUGO,
@@ -238,8 +238,8 @@ static ssize_t srf08_show_range_mm(struct device *dev,
        struct iio_dev *indio_dev = dev_to_iio_dev(dev);
        struct srf08_data *data = iio_priv(indio_dev);
 
-       return sprintf(buf, "%d.%03d\n", data->range_mm / 1000,
-                                               data->range_mm % 1000);
+       return sysfs_emit(buf, "%d.%03d\n",
+                         data->range_mm / 1000, data->range_mm % 1000);
 }
 
 /*
@@ -316,10 +316,10 @@ static ssize_t srf08_show_sensitivity_available(struct device *dev,
 
        for (i = 0; i < data->chip_info->num_sensitivity_avail; i++)
                if (data->chip_info->sensitivity_avail[i])
-                       len += sprintf(buf + len, "%d ",
-                               data->chip_info->sensitivity_avail[i]);
+                       len += sysfs_emit_at(buf, len, "%d ",
+                                            data->chip_info->sensitivity_avail[i]);
 
-       len += sprintf(buf + len, "\n");
+       len += sysfs_emit_at(buf, len, "\n");
 
        return len;
 }
@@ -332,11 +332,8 @@ static ssize_t srf08_show_sensitivity(struct device *dev,
 {
        struct iio_dev *indio_dev = dev_to_iio_dev(dev);
        struct srf08_data *data = iio_priv(indio_dev);
-       int len;
 
-       len = sprintf(buf, "%d\n", data->sensitivity);
-
-       return len;
+       return sysfs_emit(buf, "%d\n", data->sensitivity);
 }
 
 static ssize_t srf08_write_sensitivity(struct srf08_data *data,