yes, in fact, i broke it. putting back.

svn:r2918

diff --git a/src/common/log.c b/src/common/log.c
index 8c4ff3adc54754f2f0dee003f86e057b52aabb3b..80b4ada61e049bb7bba004e94d8548b73936fdd0 100644 (file)
--- a/src/common/log.c
+++ b/src/common/log.c
@@ -345,16 +345,16 @@ int add_callback_log(int loglevelMin, int loglevelMax, log_callback cb)
 /** Close any log handlers added by add_temp_log or marked by mark_logs_temp */
 void close_temp_logs(void)
 {
-  logfile_t *victim, *lf;
-  for (lf = logfiles; lf; ) {
-    if (lf->is_temporary) {
-      victim = lf;
-      lf = lf->next;
-      close_log(victim);
-      tor_free(victim->filename);
-      tor_free(victim);
+  logfile_t *lf, **p;
+  for (p = &logfiles; *p; ) {
+    if ((*p)->is_temporary) {
+      lf = *p;
+      *p = (*p)->next;
+      close_log(lf);
+      tor_free(lf->filename);
+      tor_free(lf);
     } else {
-      lf = lf->next;
+      p = &((*p)->next);
     }
   }
 }