]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dm-pcache: cleanup: fix coding style report by checkpatch.pl
authorDongsheng Yang <dongsheng.yang@linux.dev>
Mon, 1 Sep 2025 05:42:18 +0000 (05:42 +0000)
committerMikulas Patocka <mpatocka@redhat.com>
Mon, 1 Sep 2025 11:30:54 +0000 (13:30 +0200)
A patch from a few days ago fixed the division issue on 32-bit machines,
but it introduced a coding style problem.

WARNING: Missing a blank line after declarations
+       u32 rem;
+       div_u64_rem(off >> PCACHE_CACHE_SUBTREE_SIZE_SHIFT,
cache->n_ksets, &rem);

total: 0 errors, 1 warnings, 634 lines checked

Signed-off-by: Dongsheng Yang <dongsheng.yang@linux.dev>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
drivers/md/dm-pcache/cache.h

index 66eb20441409d478826722d330673ad93b387103..1136d86958c8c4520f26cb8049b3c8a79cdfab5a 100644 (file)
@@ -372,9 +372,11 @@ static inline void *get_key_head_addr(struct pcache_cache *cache)
 
 static inline u32 get_kset_id(struct pcache_cache *cache, u64 off)
 {
-       u32 rem;
-       div_u64_rem(off >> PCACHE_CACHE_SUBTREE_SIZE_SHIFT, cache->n_ksets, &rem);
-       return rem;
+       u32 kset_id;
+
+       div_u64_rem(off >> PCACHE_CACHE_SUBTREE_SIZE_SHIFT, cache->n_ksets, &kset_id);
+
+       return kset_id;
 }
 
 static inline struct pcache_cache_kset *get_kset(struct pcache_cache *cache, u32 kset_id)