]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:script: Fix shellcheck errors in test_dfree_quota.sh
authorAndreas Schneider <asn@samba.org>
Thu, 24 Feb 2022 10:41:14 +0000 (11:41 +0100)
committerPavel Filipensky <pfilipensky@samba.org>
Mon, 22 Aug 2022 14:20:36 +0000 (14:20 +0000)
source3/script/tests/test_dfree_quota.sh:125:65: error: Double quote
array expansions to avoid re-splitting elements. [SC2068]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
source3/script/tests/test_dfree_quota.sh

index e14f634920130dbdc10259e3d1c5bb4edcbbfc8d..bd036184c33ee4e7157f0f0909a81a575e435241 100755 (executable)
@@ -122,7 +122,7 @@ test_smbclient_dfree()
        shift
        subunit_start_test "$name"
        setup_conf $confs
-       output=$($VALGRIND $smbclient //$SERVER/$share -c "cd $dir; l" $@ 2>&1)
+       output=$($VALGRIND $smbclient //$SERVER/$share -c "cd $dir; l" "$@" 2>&1)
        status=$?
        if [ "$status" = "0" ]; then
                received=$(echo "$output" | awk '/blocks of size/ {print $1, $5, $6}')
@@ -150,7 +150,7 @@ test_smbclient_dfree_2()
        subunit_start_test "$name"
        setup_conf $confs
        output=$($VALGRIND $smbclient //$SERVER/$share \
-               -c "cd $dir1; du; cd ..; cd $dir2 ; du" $@ 2>&1)
+               -c "cd $dir1; du; cd ..; cd $dir2 ; du" "$@" 2>&1)
        status=$?
        if [ "$status" = "0" ]; then
                received=$(echo "$output" |
@@ -187,7 +187,7 @@ test_smbcquotas()
                mproto="-m SMB1"
        fi
 
-       output=$($VALGRIND $smbcquotas $mproto //$SERVER/dfq $@ 2>/dev/null | tr '\\' '/')
+       output=$($VALGRIND $smbcquotas $mproto //$SERVER/dfq "$@" 2>/dev/null | tr '\\' '/')
        status=$?
        if [ "$status" = "0" ]; then
                received=$(echo "$output" | awk "/$SERVER\\/$user/ {printf \"%s%s%s\", \$3, \$4, \$5}")