]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
kbuild: uapi: upgrade warning on asm/types.h inclusion to error
authorThomas Weißschuh <thomas.weissschuh@linutronix.de>
Wed, 13 Aug 2025 06:16:58 +0000 (08:16 +0200)
committerNathan Chancellor <nathan@kernel.org>
Wed, 13 Aug 2025 21:00:34 +0000 (14:00 -0700)
No usages of '#include <asm/types.h> in the UAPI headers exist anymore.

Make sure it stays this way.

Add a semicolon to the end of the previous printf call to keep the
syntax valid.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Nicolas Schier <nsc@kernel.org>
Link: https://lore.kernel.org/r/20250813-kbuild-hdrtest-fixes-v2-3-8a7921ca3a03@linutronix.de
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
usr/include/headers_check.pl

index 2b70bfa5558e64518808a22f2f926291da6e47a9..36307a137cc1e109e3e1c253f66f3e5935499fc8 100755 (executable)
@@ -98,9 +98,8 @@ sub check_asm_types
        if ($line =~ m/^\s*#\s*include\s+<asm\/types.h>/) {
                $linux_asm_types = 1;
                printf STDERR "$filename:$lineno: " .
-               "include of <linux/types.h> is preferred over <asm/types.h>\n"
-               # Warn until headers are all fixed
-               #$ret = 1;
+               "include of <linux/types.h> is preferred over <asm/types.h>\n";
+               $ret = 1;
        }
 }