]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
platform/x86: alienware-wmi-wmax: Fix NULL pointer dereference in sleep handlers
authorKurt Borja <kuurtb@gmail.com>
Tue, 14 Oct 2025 10:07:27 +0000 (05:07 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2025 13:10:22 +0000 (14:10 +0100)
commit a49c4d48c3b60926e6a8cec217bf95aa65388ecc upstream.

Devices without the AWCC interface don't initialize `awcc`. Add a check
before dereferencing it in sleep handlers.

Cc: stable@vger.kernel.org
Reported-by: Gal Hammer <galhammer@gmail.com>
Tested-by: Gal Hammer <galhammer@gmail.com>
Fixes: 07ac275981b1 ("platform/x86: alienware-wmi-wmax: Add support for manual fan control")
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
Link: https://patch.msgid.link/20251014-sleep-fix-v3-1-b5cb58da4638@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/platform/x86/dell/alienware-wmi-wmax.c

index 3b25a8283bbdd249e4be4d5a2c884d75069ed8f6..f417dcc9af355d3150d4280d86bead9199b7d6d2 100644 (file)
@@ -1647,7 +1647,7 @@ static int wmax_wmi_probe(struct wmi_device *wdev, const void *context)
 
 static int wmax_wmi_suspend(struct device *dev)
 {
-       if (awcc->hwmon)
+       if (awcc && awcc->hwmon)
                awcc_hwmon_suspend(dev);
 
        return 0;
@@ -1655,7 +1655,7 @@ static int wmax_wmi_suspend(struct device *dev)
 
 static int wmax_wmi_resume(struct device *dev)
 {
-       if (awcc->hwmon)
+       if (awcc && awcc->hwmon)
                awcc_hwmon_resume(dev);
 
        return 0;