]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/xe/device: fix XE_MAX_GT_PER_TILE check
authorMatthew Auld <matthew.auld@intel.com>
Mon, 18 Mar 2024 18:05:34 +0000 (18:05 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:37:56 +0000 (16:37 +0200)
[ Upstream commit 23e1ee3a2317f41f47d4f7255257431c5f8d1c2c ]

Here XE_MAX_GT_PER_TILE is the total, therefore the gt index should
always be less than.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240318180532.57522-5-matthew.auld@intel.com
(cherry picked from commit a5ef563b1d676548a4c5016540833ff970230964)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/xe/xe_device.h

index 08d8b72c77319a74bc34562c92ec0aab0195be42..ee8be4c6b59b1555e99c65c8aa0676fc3b1e5f69 100644 (file)
@@ -58,7 +58,7 @@ static inline struct xe_tile *xe_device_get_root_tile(struct xe_device *xe)
 
 static inline struct xe_gt *xe_tile_get_gt(struct xe_tile *tile, u8 gt_id)
 {
-       if (drm_WARN_ON(&tile_to_xe(tile)->drm, gt_id > XE_MAX_GT_PER_TILE))
+       if (drm_WARN_ON(&tile_to_xe(tile)->drm, gt_id >= XE_MAX_GT_PER_TILE))
                gt_id = 0;
 
        return gt_id ? tile->media_gt : tile->primary_gt;