]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-38962: Fix reference leak in test_httpservers (GH-17454)
authorPablo Galindo <Pablogsal@gmail.com>
Wed, 4 Dec 2019 09:29:10 +0000 (09:29 +0000)
committerVictor Stinner <vstinner@python.org>
Wed, 4 Dec 2019 09:29:10 +0000 (10:29 +0100)
Lib/test/test_httpservers.py

index 26da71e0b270179cd0ec5c3d6dcf678f229cbef6..c442f5571a86823e8e7b725e6277e292348dad15 100644 (file)
@@ -807,11 +807,15 @@ class CGIHTTPServerTestCase(BaseTestCase):
             (res.read(), res.getheader('Content-type'), res.status))
 
     def test_cgi_path_in_sub_directories(self):
-        CGIHTTPRequestHandler.cgi_directories.append('/sub/dir/cgi-bin')
-        res = self.request('/sub/dir/cgi-bin/file5.py')
-        self.assertEqual(
-            (b'Hello World' + self.linesep, 'text/html', HTTPStatus.OK),
-            (res.read(), res.getheader('Content-type'), res.status))
+        try:
+            CGIHTTPRequestHandler.cgi_directories.append('/sub/dir/cgi-bin')
+            res = self.request('/sub/dir/cgi-bin/file5.py')
+            self.assertEqual(
+                (b'Hello World' + self.linesep, 'text/html', HTTPStatus.OK),
+                (res.read(), res.getheader('Content-type'), res.status))
+        finally:
+            CGIHTTPRequestHandler.cgi_directories.remove('/sub/dir/cgi-bin')
+
 
 
 class SocketlessRequestHandler(SimpleHTTPRequestHandler):