]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfsprogs: healer: install targets one at a time
authorAllen Hewes <rallenh@hotmail.com>
Tue, 14 Jul 2026 23:21:03 +0000 (23:21 +0000)
committerAndrey Albershteyn <aalbersh@kernel.org>
Fri, 17 Jul 2026 08:22:04 +0000 (10:22 +0200)
libtool's --mode=install requires the destination to already exist
as a real directory whenever more than one source file is given
(it emulates cp/install semantics, which have the same requirement).
Installing xfs_healer and xfs_healer_start in a single LTINSTALL
call trips this check on any build where HAVE_HEALER_START_DEPS=yes,
since PKG_LIBEXEC_DIR isn't guaranteed to exist under the raw,
un-DESTDIR'd path libtool checks. Install each target separately
to avoid the multi-file directory check entirely.

Assisted-by: Claude:claude-sonnet-5
Signed-off-by: Allen Hewes <rallenh@hotmail.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
healer/Makefile

index e3c41e668da59e5766ecc74672e439ae9b35b026..4aa58757bb06310d3f54118b153a882b555152a1 100644 (file)
@@ -69,7 +69,9 @@ install: $(INSTALL_HEALER)
 
 install-healer: default
        $(INSTALL) -m 755 -d $(PKG_LIBEXEC_DIR)
-       $(LTINSTALL) -m 755 $(BUILD_TARGETS) $(PKG_LIBEXEC_DIR)
+       for f in $(BUILD_TARGETS); do \
+               $(LTINSTALL) -m 755 $$f $(PKG_LIBEXEC_DIR); \
+       done
 
 install-systemd: default
        $(INSTALL) -m 755 -d $(SYSTEMD_SYSTEM_UNIT_DIR)