staging: rtl8723bs: remove custom is_multicast_mac_addr() function

is_multicast_mac_addr() is redundant reimplementation of standard
is_multicast_ether_addr() func.
Remove it and switch to use is_multicast_ether_addr().

Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
Link: https://patch.msgid.link/20260323150650.7168-7-nikolayof23@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index 904ff0e14ec5aac6585214b6de29ecac6860bd11..c70541f95a73553ee2753c0736f55edcd53ed0d6 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -13,7 +13,7 @@ u8 rtw_validate_bssid(u8 *bssid)
 
        if (is_zero_ether_addr(bssid) ||
            is_broadcast_ether_addr(bssid) ||
-           is_multicast_mac_addr(bssid))
+           is_multicast_ether_addr(bssid))
                ret = false;
 
        return ret;

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 09cff9499a59eedb2a25cfbb918ab4da4aad6385..f78194d508dfcd2b5d9db848d2b0dc602a01eae0 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1275,7 +1275,7 @@ static signed int validate_recv_mgnt_frame(struct adapter *padapter, union recv_
                            ETH_ALEN))
                        psta->sta_stats.rx_probersp_pkts++;
                else if (is_broadcast_ether_addr(GetAddr1Ptr(precv_frame->u.hdr.rx_data)) ||
-                        is_multicast_mac_addr(GetAddr1Ptr(precv_frame->u.hdr.rx_data)))
+                        is_multicast_ether_addr(GetAddr1Ptr(precv_frame->u.hdr.rx_data)))
                        psta->sta_stats.rx_probersp_bm_pkts++;
                else
                        psta->sta_stats.rx_probersp_uo_pkts++;

diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index c3e06e6934959ac554f8503abdb13810df896c39..fbb12fe31a6c26e97cecb6fac5d549d9fc38f547 100644 (file)
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -507,11 +507,6 @@ join_res:
 #define DEFAULT_FTS 2346
 #define IP_ARG(x) (x)
 
-static inline int is_multicast_mac_addr(const u8 *addr)
-{
-       return ((addr[0] != 0xff) && (0x01 & addr[0]));
-}
-
 #define CFG_IEEE80211_RESERVE_FCS (1<<0)
 #define CFG_IEEE80211_COMPUTE_FCS (1<<1)