]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gianfar: Handle error code at MAC address change
authorClaudiu Manoil <claudiu.manoil@nxp.com>
Mon, 29 Mar 2021 14:08:47 +0000 (17:08 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Apr 2021 06:22:34 +0000 (08:22 +0200)
[ Upstream commit bff5b62585123823842833ab20b1c0a7fa437f8c ]

Handle return error code of eth_mac_addr();

Fixes: 3d23a05c75c7 ("gianfar: Enable changing mac addr when if up")
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/freescale/gianfar.c

index df03cf63cb026b2c03c1f03ddcbe73f30e330800..4feab06b7ad7a77ff2931cc52b144c92a42d14fd 100644 (file)
@@ -485,7 +485,11 @@ static struct net_device_stats *gfar_get_stats(struct net_device *dev)
 
 static int gfar_set_mac_addr(struct net_device *dev, void *p)
 {
-       eth_mac_addr(dev, p);
+       int ret;
+
+       ret = eth_mac_addr(dev, p);
+       if (ret)
+               return ret;
 
        gfar_set_mac_for_addr(dev, 0, dev->dev_addr);