Don't free storage volume in cleanup path, since it may still be referenced

diff --git a/ChangeLog b/ChangeLog
index a84e2b4b3369094f1177fa3ae2ef95f2a5382063..48d4f8fbbee2e13253f8c65205647f3eb13d00f0 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Mon Mar 16 10:30:00 GMT 2009 Daniel P. Berrange <berrange@redhat.com>
+
+       * src/storage_driver.c: Don't free storage volume in error
+       path, since it may still be referenced elsewhere
+
 Mon Mar 16 10:29:00 GMT 2009 Daniel P. Berrange <berrange@redhat.com>
 
        Avoid harmless warning message

diff --git a/src/storage_driver.c b/src/storage_driver.c
index f1320c5be7d6114fc5730bbb3feaf245a456977f..b2618436da78faf8538f6ce235833469770f5444 100644 (file)
--- a/src/storage_driver.c
+++ b/src/storage_driver.c
@@ -1296,7 +1296,6 @@ storageVolumeDelete(virStorageVolPtr obj,
     ret = 0;
 
 cleanup:
-    virStorageVolDefFree(vol);
     if (pool)
         virStoragePoolObjUnlock(pool);
     return ret;