re PR middle-end/52478 (-ftrapv calls the wrong functions in libgcc)

2014-07-28  Richard Biener  <rguenther@suse.de>

	PR middle-end/52478
	* optabs.c (gen_int_libfunc): For -ftrapv libfuncs make
	sure to register SImode ones, not only >= word_mode ones.
	* expr.c (expand_expr_real_2): When expanding -ftrapv
	binops do not use OPTAB_LIB_WIDEN.

	* gcc.dg/torture/ftrapv-1.c: New testcase.

From-SVN: r213117

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 56d3b250a03163bad30ca7278c84edc2032c0df6..fcb95b1a9cb756f46f7df145cd96449f62c5a7b0 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,11 @@
+2014-07-28  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/52478
+       * optabs.c (gen_int_libfunc): For -ftrapv libfuncs make
+       sure to register SImode ones, not only >= word_mode ones.
+       * expr.c (expand_expr_real_2): When expanding -ftrapv
+       binops do not use OPTAB_LIB_WIDEN.
+
 2014-07-28  Richard Sandiford  <rdsandiford@googlemail.com>
 
        PR middle-end/61919

diff --git a/gcc/expr.c b/gcc/expr.c
index d8328eebfbf62e676420115ba6c3d110895e5615..de0da345198819fa6ac2cce9bad0829a26cf3d4c 100644 (file)
--- a/gcc/expr.c
+++ b/gcc/expr.c
@@ -9212,7 +9212,9 @@ expand_expr_real_2 (sepops ops, rtx target, enum machine_mode tmode,
   if (modifier == EXPAND_STACK_PARM)
     target = 0;
   temp = expand_binop (mode, this_optab, op0, op1, target,
-                      unsignedp, OPTAB_LIB_WIDEN);
+                      unsignedp,
+                      trapv_binoptab_p (this_optab)
+                      ? OPTAB_LIB : OPTAB_LIB_WIDEN);
   gcc_assert (temp);
   /* Bitwise operations do not need bitfield reduction as we expect their
      operands being properly truncated.  */

diff --git a/gcc/optabs.c b/gcc/optabs.c
index 7ee84c4348c96a49e3749581b889364680ed292b..c7bd9d07485a10a6084b735eabbee2edbc61cafe 100644 (file)
--- a/gcc/optabs.c
+++ b/gcc/optabs.c
@@ -5559,13 +5559,17 @@ gen_int_libfunc (optab optable, const char *opname, char suffix,
                 enum machine_mode mode)
 {
   int maxsize = 2 * BITS_PER_WORD;
+  int minsize = BITS_PER_WORD;
 
   if (GET_MODE_CLASS (mode) != MODE_INT)
     return;
   if (maxsize < LONG_LONG_TYPE_SIZE)
     maxsize = LONG_LONG_TYPE_SIZE;
-  if (GET_MODE_CLASS (mode) != MODE_INT
-      || GET_MODE_BITSIZE (mode) < BITS_PER_WORD
+  if (minsize > INT_TYPE_SIZE
+      && (trapv_binoptab_p (optable)
+         || trapv_unoptab_p (optable)))
+    minsize = INT_TYPE_SIZE;
+  if (GET_MODE_BITSIZE (mode) < minsize
       || GET_MODE_BITSIZE (mode) > maxsize)
     return;
   gen_libfunc (optable, opname, suffix, mode);

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 68499d9eed0f14302b6ce72d2e48899686f4a7e1..014896c627c1579589c0602bc6562ef09ede3de2 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-07-28  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/52478
+       * gcc.dg/torture/ftrapv-1.c: New testcase.
+
 2014-07-28  Richard Biener  <rguenther@suse.de>
 
        PR tree-optimization/61921

diff --git a/gcc/testsuite/gcc.dg/torture/ftrapv-1.c b/gcc/testsuite/gcc.dg/torture/ftrapv-1.c
new file mode 100644 (file)
index 0000000..4fdccd8
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/ftrapv-1.c
@@ -0,0 +1,37 @@
+/* { dg-do run } */
+/* { dg-additional-options "-ftrapv" } */
+/* { dg-require-effective-target trapping } */
+/* { dg-require-fork } */
+
+#include <stdlib.h>
+#include <unistd.h>
+#include <sys/types.h>
+#include <sys/wait.h>
+
+/* Verify SImode operations properly trap.  PR middle-end/52478  */
+
+/* Disallow inlining/cloning which would constant propagate and trigger
+   unrelated bugs.  */
+
+int __attribute__((noinline,noclone))
+iaddv (int a, int b)
+{
+  return a + b;
+}
+
+int main(void)
+{
+  pid_t child = fork ();
+  int status = 0;
+  if (child == 0)
+    {
+      volatile int x = iaddv (__INT_MAX__, 1);
+      exit (0);
+    }
+  else if (child == -1)
+    return 0;
+  if (wait (&status) == child 
+      && status == 0)
+    abort ();
+  return 0;
+}