nmbd: Fix socket cleanup in make_subnet()

We can have -errno in the in those variables

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/nmbd/nmbd_subnetdb.c b/source3/nmbd/nmbd_subnetdb.c
index aefe1d4be397da24137d4b90d0c012717be49cc6..983369f0c6fd2f77e6aaee56db66eb16c784bf31 100644 (file)
--- a/source3/nmbd/nmbd_subnetdb.c
+++ b/source3/nmbd/nmbd_subnetdb.c
@@ -196,16 +196,16 @@ static struct subnet_record *make_subnet(const char *name, enum subnet_type type
 
 failed:
        SAFE_FREE(subrec);
-       if (nmb_sock != -1) {
+       if (nmb_sock >= 0) {
                close(nmb_sock);
        }
-       if (nmb_bcast != -1) {
+       if (nmb_bcast >= 0) {
                close(nmb_bcast);
        }
-       if (dgram_sock != -1) {
+       if (dgram_sock >= 0) {
                close(dgram_sock);
        }
-       if (dgram_bcast != -1) {
+       if (dgram_bcast >= 0) {
                close(dgram_bcast);
        }
        return NULL;