]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: adc: ad7768-1: Remove logically dead code
authorChandra Mohan Sundar <chandramohan.explore@gmail.com>
Sat, 16 Aug 2025 13:37:55 +0000 (19:07 +0530)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 17 Aug 2025 14:31:54 +0000 (15:31 +0100)
The clamp macro returns a value within the specified range.

In ad7768_set_freq(), the value returned from clamp() is checked against
zero, which is not possible since the value would always be between
50 and 1024000.

Removed the 'if' check.

This issue was reported by static coverity analyser as logically
dead code.

Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
Link: https://patch.msgid.link/20250816133757.98624-1-chandramohan.explore@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7768-1.c

index ca8fa91796ca49ee28539b31553f48c8f1522d0b..a27591bbf7df0b19bc938ec67b884b2eb151e6af 100644 (file)
@@ -687,8 +687,6 @@ static int ad7768_set_freq(struct ad7768_state *st,
        int ret;
 
        freq = clamp(freq, 50, 1024000);
-       if (freq == 0)
-               return -EINVAL;
 
        mclk_div = DIV_ROUND_CLOSEST(st->mclk_freq, freq * st->oversampling_ratio);
        /* Find the closest match for the desired sampling frequency */