]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
mount: let mount_add_extras() take care of remote-fs.target deps
authorLennart Poettering <lennart@poettering.net>
Wed, 28 Nov 2018 13:42:21 +0000 (14:42 +0100)
committerLennart Poettering <lennart@poettering.net>
Fri, 7 Dec 2018 16:34:29 +0000 (17:34 +0100)
In a previous commit we added logic that mount_add_extras() (or more
precisely mount_add_default_dependencies()) adds in dependencies on
remote-fs.target and local-fs.target, hence we can drop this from
mount_setup_new_unit() and let the usual load queue dispatching take
care of this.

src/core/mount.c

index d19dce094473339ce2c2aff91539e4b299b13e5e..6a0bc1075e624c8988e349c5763da7bacefad7ad 100644 (file)
@@ -1487,23 +1487,8 @@ static int mount_setup_new_unit(
         if (r < 0)
                 return r;
 
-        if (!mount_is_extrinsic(MOUNT(u))) {
-                MountParameters *p;
-                const char *target;
-
-                p = &MOUNT(u)->parameters_proc_self_mountinfo;
-
-                target = mount_is_network(p) ? SPECIAL_REMOTE_FS_TARGET : SPECIAL_LOCAL_FS_TARGET;
-                r = unit_add_dependency_by_name(u, UNIT_BEFORE, target, true, UNIT_DEPENDENCY_MOUNTINFO_IMPLICIT);
-                if (r < 0)
-                        return r;
-
-                r = unit_add_dependency_by_name(u, UNIT_CONFLICTS, SPECIAL_UMOUNT_TARGET, true, UNIT_DEPENDENCY_MOUNTINFO_IMPLICIT);
-                if (r < 0)
-                        return r;
-        }
-
         unit_add_to_load_queue(u);
+
         flags->is_mounted = true;
         flags->just_mounted = true;
         flags->just_changed = true;