]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.13] gh-69001: Convert links to more usable buttons (GH-129591) (#130338)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Thu, 20 Feb 2025 08:54:31 +0000 (09:54 +0100)
committerGitHub <noreply@github.com>
Thu, 20 Feb 2025 08:54:31 +0000 (08:54 +0000)
gh-69001: Convert links to more usable buttons (GH-129591)

In Lib/idlelib/help_about.py, there are 2 links that are not underlined or colored, hence hard to tell that clicking works.  All buttons might get converted to colored and underlined links in the future.
---------
(cherry picked from commit ed831b95a231ef949da13a261b40ee1ea0e126d7)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Lib/idlelib/help_about.py

index 81c65f6264e7b949c9cf558e998e0a83533a4fb1..750da373272298ac1801a66b7cfc0d2c3be6915a 100644 (file)
@@ -87,16 +87,19 @@ class AboutDialog(Toplevel):
         byline.grid(row=2, column=0, sticky=W, columnspan=3, padx=10, pady=5)
 
         forums_url = "https://discuss.python.org"
-        forums = Label(frame_background, text="Python forums: "+forums_url,
-                        justify=LEFT, fg=self.fg, bg=self.bg)
-        forums.grid(row=6, column=0, sticky=W, padx=10, pady=0)
-        forums.bind("<Button-1>", lambda event: webbrowser.open(forums_url))
+        forums = Button(frame_background, text='Python (and IDLE) Discussion', width=35,
+                                 highlightbackground=self.bg,
+                                 command=lambda: webbrowser.open(forums_url))
+        forums.grid(row=6, column=0, sticky=W, padx=10, pady=10)
+
+
         docs_url = ("https://docs.python.org/%d.%d/library/idle.html" %
                     sys.version_info[:2])
-        docs = Label(frame_background, text=docs_url,
-                     justify=LEFT, fg=self.fg, bg=self.bg)
-        docs.grid(row=7, column=0, columnspan=2, sticky=W, padx=10, pady=0)
-        docs.bind("<Button-1>", lambda event: webbrowser.open(docs_url))
+        docs = Button(frame_background, text='IDLE Documentation', width=35,
+                                 highlightbackground=self.bg,
+                                 command=lambda: webbrowser.open(docs_url))
+        docs.grid(row=7, column=0, columnspan=2, sticky=W, padx=10, pady=10)
+
 
         Frame(frame_background, borderwidth=1, relief=SUNKEN,
               height=2, bg=self.bg).grid(row=8, column=0, sticky=EW,