coverity thinks it's dumb to check networkstatus_v2_list in one place and not another...

svn:r17809

diff --git a/src/or/routerlist.c b/src/or/routerlist.c
index c4de128666f12beb9ac64d6ec7dbdd7977c2554a..a58976a7e9a557899231fb1df09fc29c85431521 100644 (file)
--- a/src/or/routerlist.c
+++ b/src/or/routerlist.c
@@ -3265,7 +3265,7 @@ routerlist_remove_old_routers(void)
 
   cutoff = now - OLD_ROUTER_DESC_MAX_AGE;
   /* Build a list of all the descriptors that _anybody_ lists. */
-  if (caches) {
+  if (caches && networkstatus_v2_list) {
     SMARTLIST_FOREACH(networkstatus_v2_list, networkstatus_v2_t *, ns,
     {
       /* XXXX The inner loop here gets pretty expensive, and actually shows up