]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
pytests/segfaults: dcerpc ref elements segfault
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Mon, 28 Oct 2019 23:02:04 +0000 (12:02 +1300)
committerNoel Power <npower@samba.org>
Thu, 14 Nov 2019 16:12:40 +0000 (16:12 +0000)
These are just a couple of examples.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
python/samba/tests/segfault.py
selftest/knownfail.d/python-segfaults

index 6593788315629d64b2abae771395a4160ae5f1d4..82c4e2b38069915cf2b498b8a3d86fbdb0771887 100644 (file)
@@ -25,7 +25,7 @@ import sys
 from samba.net import Net, LIBNET_JOIN_AUTOMATIC
 from samba.credentials import DONT_USE_KERBEROS
 from samba import NTSTATUSError, ntstatus
-from samba.dcerpc import misc, drsuapi
+from samba.dcerpc import misc, drsuapi, samr, unixinfo
 from samba import auth, gensec
 from samba.samdb import SamDB
 from samba import netbios
@@ -157,3 +157,15 @@ class SegfaultTests(samba.tests.TestCase):
     def test_rpcecho(self):
         from dcerpc import echo
         echo.rpcecho("")
+
+    @segfault_detector
+    def test_dcerpc_idl_ref_elements(self):
+        """There are many pidl generated functions that crashed on this
+        pattern, where a NULL pointer was created rather than an empty
+        structure."""
+        samr.Connect5().out_info_out = 1
+
+    @segfault_detector
+    def test_dcerpc_idl_unixinfo_elements(self):
+        """Dereferencing is sufficient to crash"""
+        unixinfo.GetPWUid().out_infos
index 1be0566dcb1eab45e2509718e14dff7419b27e90..4e1905ee2963a764155340cf5f00197b5f9ca686 100644 (file)
@@ -1 +1,3 @@
 samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_net_replicate_init__3
+samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_dcerpc_idl_ref_elements
+samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_dcerpc_idl_unixinfo_elements