]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:rpcclient: Initialize spoolss_DriverDirectoryInfo info
authorPavel Filipenský <pfilipensky@samba.org>
Wed, 3 Jul 2024 15:33:20 +0000 (17:33 +0200)
committerVolker Lendecke <vl@samba.org>
Fri, 5 Jul 2024 07:45:32 +0000 (07:45 +0000)
Error: UNINIT (CWE-457):
samba-4.20.0rc2/source3/rpcclient/cmd_spoolss.c:1530: var_decl: Declaring variable "info" without initializer.
samba-4.20.0rc2/source3/rpcclient/cmd_spoolss.c:1578: uninit_use_in_call: Using uninitialized value "info" when calling "display_printdriverdir_1".
 1576|
 1577|           if (W_ERROR_IS_OK(result)) {
 1578|->                 display_printdriverdir_1(&info.info1);
 1579|           }
 1580|

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
source3/rpcclient/cmd_spoolss.c

index 40ee3e7f87454b417fea40defc9be0d4d120dc4d..17ba74c333f1008b7d8f2f3e7503d80e6a2d1d9e 100644 (file)
@@ -1527,7 +1527,7 @@ static WERROR cmd_spoolss_getdriverdir(struct rpc_pipe_client *cli,
        const char *env = SPOOLSS_ARCHITECTURE_NT_X86;
        DATA_BLOB buffer;
        uint32_t offered;
-       union spoolss_DriverDirectoryInfo info;
+       union spoolss_DriverDirectoryInfo info = {};
        uint32_t needed;
        struct dcerpc_binding_handle *b = cli->binding_handle;