]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: SDCA: Add allocation failure check for Entity name
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Tue, 3 Mar 2026 14:17:07 +0000 (14:17 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 3 Mar 2026 14:23:32 +0000 (14:23 +0000)
Currently find_sdca_entity_iot() can allocate a string for the
Entity name but it doesn't check if that allocation succeeded.
Add the missing NULL check after the allocation.

Fixes: 48fa77af2f4a ("ASoC: SDCA: Add terminal type into input/output widget name")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20260303141707.3841635-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sdca/sdca_functions.c

index 95b67bb904c313f02bd0f380c169e4800769cb4e..e0ed593697ba01d8eca1ef521e39542e9d765671 100644 (file)
@@ -1156,9 +1156,12 @@ static int find_sdca_entity_iot(struct device *dev,
        if (!terminal->is_dataport) {
                const char *type_name = sdca_find_terminal_name(terminal->type);
 
-               if (type_name)
+               if (type_name) {
                        entity->label = devm_kasprintf(dev, GFP_KERNEL, "%s %s",
                                                       entity->label, type_name);
+                       if (!entity->label)
+                               return -ENOMEM;
+               }
        }
 
        ret = fwnode_property_read_u32(entity_node,