]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
x86/ioapic: Simplify mp_irqdomain_alloc() slightly
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 19 Oct 2025 08:18:20 +0000 (10:18 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 21 Oct 2025 06:47:33 +0000 (08:47 +0200)
The IRQ return value of irq_find_mapping() is only tested
for existence, not used for anything else.

So, this call can be replaced by a slightly simpler
irq_resolve_mapping() call, which reduces generated
code size a bit (x86-64 allmodconfig):

   text    data     bss     dec     hex filename
  82142   38633   18048  138823   21e47 arch/x86/kernel/apic/io_apic.o.before
  81932   38633   18048  138613   21d75 arch/x86/kernel/apic/io_apic.o.after

[ mingo: Fixed & simplified the changelog ]

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Link: https://patch.msgid.link/cb3a4968538637aac3a5ae4f5ecc4f5eb43376ea.1760861877.git.christophe.jaillet@wanadoo.fr
arch/x86/kernel/apic/io_apic.c

index 5ba2feb2c04c6d7a7fa4cbe64847db433773102d..1e0442e867b1c168239792a386d930d220cdb69a 100644 (file)
@@ -2864,7 +2864,7 @@ int mp_irqdomain_alloc(struct irq_domain *domain, unsigned int virq,
 
        ioapic = mp_irqdomain_ioapic_idx(domain);
        pin = info->ioapic.pin;
-       if (irq_find_mapping(domain, (irq_hw_number_t)pin) > 0)
+       if (irq_resolve_mapping(domain, (irq_hw_number_t)pin))
                return -EEXIST;
 
        data = kzalloc(sizeof(*data), GFP_KERNEL);