Coverity 1038134 fix

Cleaned up error check. "ipdup" can only be non-NULL there, so remove check
that confused coverity.

diff --git a/src/detect-engine-address.c b/src/detect-engine-address.c
index 64f954b3f5bcf47d61c6ebc0d3f4bd6f861e9be9..9e2d9356ca65db8d58e29a69fdf6591776636141 100644 (file)
--- a/src/detect-engine-address.c
+++ b/src/detect-engine-address.c
@@ -605,7 +605,6 @@ int DetectAddressParseString(DetectAddress *dd, char *str)
         str++;
 
     char *ipdup = SCStrdup(str);
-
     if (unlikely(ipdup == NULL))
         return -1;
     SCLogDebug("str %s", str);
@@ -765,8 +764,7 @@ int DetectAddressParseString(DetectAddress *dd, char *str)
     return 0;
 
 error:
-    if (ipdup)
-        SCFree(ipdup);
+    SCFree(ipdup);
     return -1;
 }