]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
vhost: Do not abort on log-stop error
authorHanna Czenczek <hreitz@redhat.com>
Thu, 24 Jul 2025 12:59:28 +0000 (14:59 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Sat, 2 Aug 2025 05:12:53 +0000 (08:12 +0300)
Failing to stop logging in a vhost device is not exactly fatal.  We can
log such an error, but there is no need to abort the whole qemu process
because of it.

Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20250724125928.61045-3-hreitz@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Tested-by: Lei Yang <leiyang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit d63c388dadb7717f6391e1bb7f11728c0c1a3e36)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/virtio/vhost.c

index 26e5a67653dba0964841011bbfdf508463a9513b..e72d991c55d1266e038cc4864c6f485598be782d 100644 (file)
@@ -1123,7 +1123,8 @@ static void vhost_log_global_stop(MemoryListener *listener)
 
     r = vhost_migration_log(listener, false);
     if (r < 0) {
-        abort();
+        /* Not fatal, so report it, but take no further action */
+        warn_report("vhost: Failed to stop logging");
     }
 }