better error checks for failure conditions (based on Puneet Pawaia's reports)

diff --git a/lib/ftp.c b/lib/ftp.c
index 53f8df14ecc0d42a1de517b9586292f00226ed5b..701b497e6cbfd43a4562d82cd4aa05b5fd96b328 100644 (file)
--- a/lib/ftp.c
+++ b/lib/ftp.c
@@ -1720,12 +1720,14 @@ CURLcode Curl_ftp_disconnect(struct connectdata *conn)
 {
   struct FTP *ftp= conn->proto.ftp;
 
-  if(ftp->user)
-    free(ftp->user);
-  if(ftp->passwd)
-    free(ftp->passwd);
-  if(ftp->entrypath)
-    free(ftp->entrypath);
-
+  /* The FTP session may or may not have been allocated/setup at this point! */
+  if(ftp) {
+    if(ftp->user)
+      free(ftp->user);
+    if(ftp->passwd)
+      free(ftp->passwd);
+    if(ftp->entrypath)
+      free(ftp->entrypath);
+  }
   return CURLE_OK;
 }

diff --git a/lib/transfer.c b/lib/transfer.c
index 1f2c6886fec140360fd4b3260290f5ccbbdccab9..48706c5441033f39ba50194d3cda21e833906242 100644 (file)
--- a/lib/transfer.c
+++ b/lib/transfer.c
@@ -955,7 +955,7 @@ CURLcode Curl_perform(CURL *curl)
 
   } while(1); /* loop if Location: */
 
-  if(conn->newurl) {
+  if((CURLE_OK == res) && conn->newurl) {
     free(conn->newurl);
     conn->newurl = NULL;
   }

diff --git a/lib/url.c b/lib/url.c
index 2840d32e5a7aa9df1e18845acff6ea233ac4dd7a..5bb34be71cafb0efb1b2d9b3a204f5a725c4d0eb 100644 (file)
--- a/lib/url.c
+++ b/lib/url.c
@@ -816,6 +816,9 @@ CURLcode Curl_disconnect(struct connectdata *conn)
     free(conn->hostent_buf);
 #endif
 
+  if(conn->newurl)
+    free(conn->newurl);
+
   if(conn->path) /* the URL path part */
     free(conn->path);
 
@@ -2147,8 +2150,10 @@ CURLcode Curl_connect(struct UrlData *data,
     /* We're not allowed to return failure with memory left allocated
        in the connectdata struct, free those here */
     conn = (struct connectdata *)*in_connect;
-    if(conn)
+    if(conn) {
       Curl_disconnect(conn);      /* close the connection */
+      *in_connect = NULL;         /* return a NULL */
+    }
   }
   return code;
 }