Add a ! to directory_caches_dir_info() to fix a logic error

We want to fetch directory info more aggressively if we need it to
refuseunknownexits.  Thus, we'll want it if our exit policy is _NOT_
reject *.

diff --git a/changes/caches_if_exit b/changes/caches_if_exit
new file mode 100644 (file)
index 0000000..0e66227
--- /dev/null
+++ b/changes/caches_if_exit
@@ -0,0 +1,5 @@
+  o Minor bugfixes:
+    - Fix a logic error where servers that _didn't_ act as exits would
+      try to keep their server lists more aggressively up to date than
+      exits, when it was supposed to be the other way around. Bugfix
+      on 0.2.2.17-alpha.

diff --git a/src/or/dirserv.c b/src/or/dirserv.c
index 8ae03424a205d9b1d257523202a311e5e84a0d3d..8d0ec981a7f96517173b590b5b08817bb1e7d3ed 100644 (file)
--- a/src/or/dirserv.c
+++ b/src/or/dirserv.c
@@ -1213,7 +1213,7 @@ directory_caches_dir_info(or_options_t *options)
     return 0;
   /* We need an up-to-date view of network info if we're going to try to
    * block exit attempts from unknown relays. */
-  return router_my_exit_policy_is_reject_star() &&
+  return ! router_my_exit_policy_is_reject_star() &&
     should_refuse_unknown_exits(options);
 }