]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
Revert "gpib: cb7210: Fix region leak when request_irq fails"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 May 2026 10:29:07 +0000 (12:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 May 2026 10:29:07 +0000 (12:29 +0200)
This reverts commit 5ad28496055858166eb2268344c8fda2c26d3561.

Turns out not to be correct.

Link: https://lore.kernel.org/r/PpNUbGhrvT8I_KayoDvQYI2PYjmMw1QEkuVBDZz2PwBsVVgPkBXJarc2mBM0IhiH3AQG0GtgqEsDRXNj3yUKEDBaZa25u73pAjvcE6vfRsg=@protonmail.com
Reported-by: Dominik Karol PiÄ…tkowski <dominik.karol.piatkowski@protonmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Hongling Zeng <zhongling0719@126.com>
Cc: Hongling Zeng <zenghongling@kylinos.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpib/cb7210/cb7210.c

index 05058bf2cd50bc6f666b4c88d0bc6aeb14d7ec0c..6dd8637c5964b358874a5981587e2040195aa67a 100644 (file)
@@ -1062,7 +1062,6 @@ static int cb_isa_attach(struct gpib_board *board, const struct gpib_board_confi
        // install interrupt handler
        if (request_irq(config->ibirq, cb7210_interrupt, isr_flags, DRV_NAME, board)) {
                dev_err(board->gpib_dev, "failed to obtain IRQ %d\n", config->ibirq);
-               release_region(nec7210_iobase(cb_priv), cb7210_iosize);
                return -EBUSY;
        }
        cb_priv->irq = config->ibirq;