]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpu: nova-core: vbios: change PmuLookupTableEntry to use size_of
authorRhys Lloyd <krakow20@gmail.com>
Fri, 18 Jul 2025 07:36:25 +0000 (00:36 -0700)
committerAlexandre Courbot <acourbot@nvidia.com>
Tue, 12 Aug 2025 00:58:23 +0000 (09:58 +0900)
Annotate the PmuLookupTableEntry with an `#[repr(C, packed)]` attribute.
Removes another magic number by making the struct the same size as the
data it needs to read, allowing the use of
`size_of::<PmuLookupTableEntry>()`

[acourbot@nvidia.com: remove `dead_code` expect to fix `unfulfilled_lint_expectations` lint]

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Rhys Lloyd <krakow20@gmail.com>
Link: https://lore.kernel.org/r/20250718073633.194032-3-krakow20@gmail.com
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
drivers/gpu/nova-core/vbios.rs

index b4bca1919d8f91412d8bd135cf1b602cc7753114..50fbea69fc0038255a0a2b8f7bad57cd55eb65a2 100644 (file)
@@ -892,7 +892,7 @@ impl TryFrom<BiosImageBase> for PciAtBiosImage {
 /// The [`PmuLookupTableEntry`] structure is a single entry in the [`PmuLookupTable`].
 ///
 /// See the [`PmuLookupTable`] description for more information.
-#[expect(dead_code)]
+#[repr(C, packed)]
 struct PmuLookupTableEntry {
     application_id: u8,
     target_id: u8,
@@ -901,7 +901,7 @@ struct PmuLookupTableEntry {
 
 impl PmuLookupTableEntry {
     fn new(data: &[u8]) -> Result<Self> {
-        if data.len() < 6 {
+        if data.len() < core::mem::size_of::<Self>() {
             return Err(EINVAL);
         }