]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: ahash - Fix early termination in hash walk
authorHerbert Xu <herbert@gondor.apana.org.au>
Mon, 26 Mar 2018 00:53:25 +0000 (08:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 8 Apr 2018 09:49:48 +0000 (11:49 +0200)
commit 900a081f6912a8985dc15380ec912752cb66025a upstream.

When we have an unaligned SG list entry where there is no leftover
aligned data, the hash walk code will incorrectly return zero as if
the entire SG list has been processed.

This patch fixes it by moving onto the next page instead.

Reported-by: Eli Cooper <elicooper@gmx.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/ahash.c

index 0735529ea082bad04b1dde22f8d2f0b58012f123..6ae2b2fd72bac79f7e29fbd3ed8d2d2a54c47d2e 100644 (file)
@@ -90,13 +90,14 @@ int crypto_hash_walk_done(struct crypto_hash_walk *walk, int err)
 
        if (nbytes && walk->offset & alignmask && !err) {
                walk->offset = ALIGN(walk->offset, alignmask + 1);
-               walk->data += walk->offset;
-
                nbytes = min(nbytes,
                             ((unsigned int)(PAGE_SIZE)) - walk->offset);
                walk->entrylen -= nbytes;
 
-               return nbytes;
+               if (nbytes) {
+                       walk->data += walk->offset;
+                       return nbytes;
+               }
        }
 
        if (walk->flags & CRYPTO_ALG_ASYNC)