]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
hwmon: (xgene-hwmon) use appropriate type for the latency value
authorAndrey Vatoropin <a.vatoropin@crpt.ru>
Tue, 4 Feb 2025 09:54:08 +0000 (09:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:37:05 +0000 (14:37 +0200)
[ Upstream commit 8df0f002827e18632dcd986f7546c1abf1953a6f ]

The expression PCC_NUM_RETRIES * pcc_chan->latency is currently being
evaluated using 32-bit arithmetic.

Since a value of type 'u64' is used to store the eventual result,
and this result is later sent to the function usecs_to_jiffies with
input parameter unsigned int, the current data type is too wide to
store the value of ctx->usecs_lat.

Change the data type of "usecs_lat" to a more suitable (narrower) type.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Vatoropin <a.vatoropin@crpt.ru>
Link: https://lore.kernel.org/r/20250204095400.95013-1-a.vatoropin@crpt.ru
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/xgene-hwmon.c

index 559a73bab51e80d569d7c3e91f074568cec2f22c..15889bcc858757eae83bdb9fae316cbbfe3f9935 100644 (file)
@@ -110,7 +110,7 @@ struct xgene_hwmon_dev {
 
        phys_addr_t             comm_base_addr;
        void                    *pcc_comm_addr;
-       u64                     usecs_lat;
+       unsigned int            usecs_lat;
 };
 
 /*