]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
Revert "PCI: imx6: Skip controller_id generation logic for i.MX7D"
authorRyan Matthews <ryanmatthews@fastmail.com>
Sun, 4 May 2025 19:13:55 +0000 (15:13 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 May 2025 07:43:55 +0000 (09:43 +0200)
This reverts commit 2a12efc567a270a155e3b886258297abd79cdea0 which is
commit f068ffdd034c93f0c768acdc87d4d2d7023c1379 upstream.

This is a backport mistake.

Deleting "IMX7D" here skips more than just controller_id logic. It skips
reset assignments too, which causes:

 imx6q-pcie 33800000.pcie: PCIe PLL lock timeout

In my case, in addition to broken PCIe, kernel boot hangs entirely.

This isn't a problem upstream because before this, they moved the rest of
the code out of the switch case.

Signed-off-by: Ryan Matthews <ryanmatthews@fastmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pci/controller/dwc/pci-imx6.c

index 822a750b064b2797cf9717f54d12b82d790b7e6d..20c8f2cba45367c6fa814ad40d686868bafc15fe 100644 (file)
@@ -1281,6 +1281,7 @@ static int imx6_pcie_probe(struct platform_device *pdev)
        switch (imx6_pcie->drvdata->variant) {
        case IMX8MQ:
        case IMX8MQ_EP:
+       case IMX7D:
                if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
                        imx6_pcie->controller_id = 1;