]> git.ipfire.org Git - pakfire.git/commitdiff
python: Increase i when copying environment
authorMichael Tremer <michael.tremer@ipfire.org>
Wed, 13 Jan 2021 22:55:39 +0000 (22:55 +0000)
committerMichael Tremer <michael.tremer@ipfire.org>
Wed, 13 Jan 2021 22:55:39 +0000 (22:55 +0000)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/_pakfire/pakfire.c

index 797051dce9c51430efb598d4ca101a690808c1cd..105049fe68932c6beb13747fc022d5dcf83e290e 100644 (file)
@@ -423,12 +423,11 @@ static PyObject* Pakfire_execute(PakfireObject* self, PyObject* args, PyObject*
                p = 0;
 
                while (PyDict_Next(environ, &p, &key, &value)) {
-                       int r = asprintf(&envp[i], "%s=%s", PyUnicode_AsUTF8(key), PyUnicode_AsUTF8(value));
+                       int r = asprintf(&envp[i++], "%s=%s",
+                               PyUnicode_AsUTF8(key), PyUnicode_AsUTF8(value));
 
                        // Handle errors
                        if (r < 0) {
-                               envp[i] = NULL;
-
                                // Cleanup
                                for (unsigned int i = 0; envp[i]; i++)
                                        free(envp[i]);