]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
tracing: Move trace_iterator_increment() into trace_find_next_entry_inc()
authorSteven Rostedt <rostedt@goodmis.org>
Thu, 21 May 2026 13:50:26 +0000 (09:50 -0400)
committerSteven Rostedt <rostedt@goodmis.org>
Thu, 21 May 2026 22:16:35 +0000 (18:16 -0400)
trace_iterator_increment() is only called from trace_find_next_entry_inc().
It's a small enough function that really doesn't need to be separated.

Move the code from trace_iterator_increment() into
trace_find_next_entry_inc() and remove trace_iterator_increment().

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/20260521095026.20c9799d@gandalf.local.home
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace.c

index 4218c174460bc6adee893c10c4a31dd0abe2424d..ae527c419508c58b2ab3960d398fbed33a6c8e7b 100644 (file)
@@ -2338,15 +2338,6 @@ void trace_last_func_repeats(struct trace_array *tr,
        __buffer_unlock_commit(buffer, event);
 }
 
-static void trace_iterator_increment(struct trace_iterator *iter)
-{
-       struct ring_buffer_iter *buf_iter = trace_buffer_iter(iter, iter->cpu);
-
-       iter->idx++;
-       if (buf_iter)
-               ring_buffer_iter_advance(buf_iter);
-}
-
 static struct trace_entry *
 peek_next_entry(struct trace_iterator *iter, int cpu, u64 *ts,
                unsigned long *lost_events)
@@ -2676,11 +2667,17 @@ struct trace_entry *trace_find_next_entry(struct trace_iterator *iter,
 /* Find the next real entry, and increment the iterator to the next entry */
 void *trace_find_next_entry_inc(struct trace_iterator *iter)
 {
+       struct ring_buffer_iter *buf_iter;
+
        iter->ent = __find_next_entry(iter, &iter->cpu,
                                      &iter->lost_events, &iter->ts);
 
-       if (iter->ent)
-               trace_iterator_increment(iter);
+       if (iter->ent) {
+               iter->idx++;
+               buf_iter = trace_buffer_iter(iter, iter->cpu);
+               if (buf_iter)
+                       ring_buffer_iter_advance(buf_iter);
+       }
 
        return iter->ent ? iter : NULL;
 }