]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
staging: rtl8723bs: split multiple assignment in rtw_mgmt_xmitframe_coalesce
authorMarco Antonio Solis Segura <mshdevv@gmail.com>
Thu, 19 Mar 2026 06:26:26 +0000 (00:26 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Mar 2026 08:30:17 +0000 (10:30 +0200)
Cleanup the multiple assignment of tmp_buf and BIP_AAD to fix the
checkpatch.pl CHECK: "Multiple assignments should be avoided".

Additionally, reorder the assignments to ensure tmp_buf is assigned
only after BIP_AAD has been validated as non-NULL.

Signed-off-by: Marco Antonio Solis Segura <mshdevv@gmail.com>
Link: https://patch.msgid.link/20260319062626.605200-1-mshdevv@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_xmit.c

index 114b2c057f28a64dca562862663ae5521240a039..7bce0343d59f1330745f32ee407a2420bcdeb43d 100644 (file)
@@ -1196,12 +1196,13 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, s
        pwlanhdr = (struct ieee80211_hdr *)pframe;
 
        ori_len = BIP_AAD_SIZE + pattrib->pktlen;
-       tmp_buf = BIP_AAD = kzalloc(ori_len, GFP_ATOMIC);
-       subtype = GetFrameSubType(pframe); /* bit(7)~bit(2) */
+       BIP_AAD = kzalloc(ori_len, GFP_ATOMIC);
 
        if (!BIP_AAD)
                return _FAIL;
 
+       tmp_buf = BIP_AAD;
+       subtype = GetFrameSubType(pframe); /* bit(7)~bit(2) */
        spin_lock_bh(&padapter->security_key_mutex);
 
        /* only support station mode */