]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
sd-device-enumerator: fix typo: contolC -> controlC
authorYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 10 Mar 2022 10:03:23 +0000 (19:03 +0900)
committerLennart Poettering <lennart@poettering.net>
Fri, 18 Mar 2022 08:43:09 +0000 (09:43 +0100)
Also shorten code a bit.

src/libsystemd/sd-device/device-enumerator.c

index 4f1719b3ed29b6c71088462007b6a680420e0d5c..4942ee43a871e10b0dd67ef6a6ad667ed3dfd823 100644 (file)
@@ -249,18 +249,15 @@ static int device_compare(sd_device * const *_a, sd_device * const *_b) {
 
                         prefix_len = sound_a - devpath_a;
 
-                        if (strncmp(devpath_a, devpath_b, prefix_len) == 0) {
+                        if (strneq(devpath_a, devpath_b, prefix_len)) {
                                 const char *sound_b;
 
                                 sound_b = devpath_b + prefix_len;
 
-                                if (startswith(sound_a, "/controlC") &&
-                                    !startswith(sound_b, "/contolC"))
-                                        return 1;
-
-                                if (!startswith(sound_a, "/controlC") &&
-                                    startswith(sound_b, "/controlC"))
-                                        return -1;
+                                r = CMP(!!startswith(sound_a, "/controlC"),
+                                        !!startswith(sound_b, "/controlC"));
+                                if (r != 0)
+                                        return r;
                         }
                 }
         }