]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
black: address check failures against 23.1.0
authorYou-Sheng Yang <vicamo@gmail.com>
Thu, 6 Apr 2023 16:10:41 +0000 (00:10 +0800)
committerStephen Finucane <stephenfinucane@hotmail.com>
Thu, 6 Apr 2023 16:36:50 +0000 (17:36 +0100)
Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
79 files changed:
patchwork/api/bundle.py
patchwork/api/check.py
patchwork/api/comment.py
patchwork/api/cover.py
patchwork/api/embedded.py
patchwork/api/event.py
patchwork/api/filters.py
patchwork/api/patch.py
patchwork/api/person.py
patchwork/api/project.py
patchwork/api/series.py
patchwork/api/user.py
patchwork/apps.py
patchwork/filters.py
patchwork/forms.py
patchwork/management/commands/cron.py
patchwork/migrations/0001_initial.py
patchwork/migrations/0001_squashed_0040_add_related_patches.py
patchwork/migrations/0002_fix_patch_state_default_values.py
patchwork/migrations/0003_add_check_model.py
patchwork/migrations/0004_add_delegation_rule_model.py
patchwork/migrations/0005_unselectable_maintainer_projects.py
patchwork/migrations/0006_add_patch_diff.py
patchwork/migrations/0007_move_comment_content_to_patch_content.py
patchwork/migrations/0008_add_email_mixin.py
patchwork/migrations/0009_add_submission_model.py
patchwork/migrations/0010_migrate_data_from_submission_to_patch.py
patchwork/migrations/0011_remove_temp_fields.py
patchwork/migrations/0012_add_coverletter_model.py
patchwork/migrations/0013_slug_check_context.py
patchwork/migrations/0014_remove_userprofile_primary_project.py
patchwork/migrations/0015_add_series_models.py
patchwork/migrations/0016_series_project.py
patchwork/migrations/0017_improved_delegation_rule_docs.py
patchwork/migrations/0018_add_event_model.py
patchwork/migrations/0019_userprofile_show_ids.py
patchwork/migrations/0020_tag_show_column.py
patchwork/migrations/0021_django_1_10_fixes.py
patchwork/migrations/0022_add_subject_match_to_project.py
patchwork/migrations/0023_timezone_unify.py
patchwork/migrations/0025_add_regex_validators.py
patchwork/migrations/0026_add_user_bundles_backref.py
patchwork/migrations/0027_remove_series_ordering.py
patchwork/migrations/0028_add_comment_date_index.py
patchwork/migrations/0029_add_list_covering_index.py
patchwork/migrations/0030_add_submission_covering_index.py
patchwork/migrations/0031_add_patch_series_fields.py
patchwork/migrations/0032_migrate_data_from_series_patch_to_patch.py
patchwork/migrations/0033_remove_patch_series_model.py
patchwork/migrations/0034_project_list_archive_url.py
patchwork/migrations/0035_project_list_archive_url_format.py
patchwork/migrations/0036_project_commit_url_format.py
patchwork/migrations/0037_event_actor.py
patchwork/migrations/0038_state_slug.py
patchwork/migrations/0039_unique_series_references.py
patchwork/migrations/0040_add_related_patches.py
patchwork/migrations/0041_python3.py
patchwork/migrations/0042_add_cover_model.py
patchwork/migrations/0043_merge_patch_submission.py
patchwork/migrations/0044_add_project_linkname_validation.py
patchwork/migrations/0045_addressed_fields.py
patchwork/migrations/0046_patch_comment_events.py
patchwork/models.py
patchwork/notifications.py
patchwork/paginator.py
patchwork/parser.py
patchwork/signals.py
patchwork/templatetags/listurl.py
patchwork/templatetags/person.py
patchwork/templatetags/syntax.py
patchwork/tests/api/utils.py
patchwork/tests/test_parser.py
patchwork/tests/test_tags.py
patchwork/tests/test_xmlrpc.py
patchwork/tests/views/test_bundles.py
patchwork/tests/views/test_patch.py
patchwork/views/__init__.py
patchwork/views/notification.py
patchwork/views/xmlrpc.py

index 134b2724d5991bbd5a188b7e30b0e1427fcd0be8..dbf63a14508828db0fe19baeb242d9716c64da06 100644 (file)
@@ -61,7 +61,6 @@ class BundlePermission(permissions.BasePermission):
 
 
 class BundleSerializer(BaseHyperlinkedModelSerializer):
-
     web_url = SerializerMethodField()
     project = ProjectSerializer(read_only=True)
     mbox = SerializerMethodField()
@@ -133,7 +132,6 @@ class BundleSerializer(BaseHyperlinkedModelSerializer):
 
 
 class BundleMixin(object):
-
     permission_classes = [PatchworkPermission & BundlePermission]
     serializer_class = BundleSerializer
 
index f5461fc66ad1b5f5a82a8f8248eb59fed7cc9c76..348111ae793a23d2413a0db2cd46a815171c1963 100644 (file)
@@ -24,7 +24,6 @@ from patchwork.models import Patch
 
 
 class CheckSerializer(HyperlinkedModelSerializer):
-
     url = NestedHyperlinkedIdentityField(
         'api-check-detail',
         lookup_field_mapping={
@@ -85,7 +84,6 @@ class CheckSerializer(HyperlinkedModelSerializer):
 
 
 class CheckMixin(object):
-
     serializer_class = CheckSerializer
     filter_class = filterset_class = CheckFilterSet
 
index eae837191b7c714dae6f72dfbeef0231b438988c..88707b84c45c493f93316aaf8183bd90f0a5fff8 100644 (file)
@@ -25,7 +25,6 @@ from patchwork.models import PatchComment
 
 
 class BaseCommentListSerializer(BaseHyperlinkedModelSerializer):
-
     web_url = SerializerMethodField()
     subject = SerializerMethodField()
     headers = SerializerMethodField()
@@ -93,7 +92,6 @@ class BaseCommentListSerializer(BaseHyperlinkedModelSerializer):
 
 
 class CoverCommentSerializer(BaseCommentListSerializer):
-
     url = NestedHyperlinkedIdentityField(
         'api-cover-comment-detail',
         lookup_field_mapping={
@@ -114,7 +112,6 @@ class CoverCommentSerializer(BaseCommentListSerializer):
 
 
 class CoverCommentMixin(object):
-
     permission_classes = (PatchworkPermission,)
     serializer_class = CoverCommentSerializer
 
@@ -135,7 +132,6 @@ class CoverCommentMixin(object):
 
 
 class PatchCommentSerializer(BaseCommentListSerializer):
-
     url = NestedHyperlinkedIdentityField(
         'api-patch-comment-detail',
         lookup_field_mapping={
@@ -156,7 +152,6 @@ class PatchCommentSerializer(BaseCommentListSerializer):
 
 
 class PatchCommentMixin(object):
-
     permission_classes = (PatchworkPermission,)
     serializer_class = PatchCommentSerializer
 
index 7645c7119c71cb9fa7843ed93b8b4c6d2287cbcd..ee6b301c41f5b6259bc052d27f3a148147ec49bd 100644 (file)
@@ -19,7 +19,6 @@ from patchwork.models import Cover
 
 
 class CoverListSerializer(BaseHyperlinkedModelSerializer):
-
     web_url = SerializerMethodField()
     project = ProjectSerializer(read_only=True)
     submitter = PersonSerializer(read_only=True)
@@ -75,7 +74,6 @@ class CoverListSerializer(BaseHyperlinkedModelSerializer):
 
 
 class CoverDetailSerializer(CoverListSerializer):
-
     headers = SerializerMethodField()
 
     def get_headers(self, instance):
index 52018435df04840fc44b06c19f7ffc7f0ce2137f..389b34c4094eca113a1e512a24fcb2e61ee3940d 100644 (file)
@@ -79,7 +79,6 @@ class WebURLMixin(BaseHyperlinkedModelSerializer):
 
 class CheckSerializer(SerializedRelatedField):
     class _Serializer(BaseHyperlinkedModelSerializer):
-
         url = NestedHyperlinkedIdentityField(
             'api-check-detail',
             lookup_field_mapping={
@@ -135,7 +134,6 @@ class CoverSerializer(SerializedRelatedField):
 
 class CoverCommentSerializer(SerializedRelatedField):
     class _Serializer(MboxMixin, WebURLMixin, BaseHyperlinkedModelSerializer):
-
         url = NestedHyperlinkedIdentityField(
             'api-cover-comment-detail',
             lookup_field_mapping={
@@ -198,7 +196,6 @@ class PatchSerializer(SerializedRelatedField):
 
 class PatchCommentSerializer(SerializedRelatedField):
     class _Serializer(MboxMixin, WebURLMixin, BaseHyperlinkedModelSerializer):
-
         url = NestedHyperlinkedIdentityField(
             'api-patch-comment-detail',
             lookup_field_mapping={
@@ -246,7 +243,6 @@ class PersonSerializer(SerializedRelatedField):
 
 class ProjectSerializer(SerializedRelatedField):
     class _Serializer(BaseHyperlinkedModelSerializer):
-
         link_name = CharField(max_length=255, source='linkname')
         list_id = CharField(max_length=255, source='listid')
         list_email = CharField(max_length=200, source='listemail')
@@ -326,7 +322,6 @@ class UserSerializer(SerializedRelatedField):
 
 class UserProfileSerializer(SerializedRelatedField):
     class _Serializer(BaseHyperlinkedModelSerializer):
-
         username = CharField(source='user.username')
         first_name = CharField(source='user.first_name')
         last_name = CharField(source='user.last_name')
index 6d08b6ee80b0a8aeb9b0c60099a088df9aaea457..1d046155aa8c779050d2efff869b8bd8928e5f64 100644 (file)
@@ -24,7 +24,6 @@ from patchwork.models import Event
 
 
 class EventSerializer(ModelSerializer):
-
     project = ProjectSerializer(read_only=True)
     actor = UserSerializer()
     patch = PatchSerializer(read_only=True)
index edba3ccfbb294f399c6a55bd9048e3413bedd244..e332c5316c2e12823eec7746cdaa55e2ed4d6719 100644 (file)
@@ -94,32 +94,26 @@ class ModelMultipleChoiceField(BaseMultipleChoiceField):
 
 
 class BaseField(ModelMultipleChoiceField):
-
     alternate_lookup = None
 
 
 class BaseFilter(ModelMultipleChoiceFilter):
-
     field_class = BaseField
 
 
 class PersonChoiceField(ModelMultipleChoiceField):
-
     alternate_lookup = 'email__iexact'
 
 
 class PersonFilter(ModelMultipleChoiceFilter):
-
     field_class = PersonChoiceField
 
 
 class ProjectChoiceField(ModelMultipleChoiceField):
-
     alternate_lookup = 'linkname__iexact'
 
 
 class ProjectFilter(ModelMultipleChoiceFilter):
-
     field_class = ProjectChoiceField
 
 
@@ -132,17 +126,14 @@ class StateChoiceField(ModelMultipleChoiceField):
 
 
 class StateFilter(ModelMultipleChoiceFilter):
-
     field_class = StateChoiceField
 
 
 class UserChoiceField(ModelMultipleChoiceField):
-
     alternate_lookup = 'username__iexact'
 
 
 class UserFilter(ModelMultipleChoiceFilter):
-
     field_class = UserChoiceField
 
 
@@ -166,14 +157,12 @@ class BaseFilterSet(FilterSet):
 
 
 class TimestampMixin(BaseFilterSet):
-
     # TODO(stephenfin): These should filter on a 'updated_at' field instead
     before = IsoDateTimeFilter(lookup_expr='lt', field_name='date')
     since = IsoDateTimeFilter(lookup_expr='gte', field_name='date')
 
 
 class SeriesFilterSet(TimestampMixin, BaseFilterSet):
-
     submitter = PersonFilter(queryset=Person.objects.all(), distinct=False)
     project = ProjectFilter(queryset=Project.objects.all(), distinct=False)
 
@@ -187,7 +176,6 @@ def msgid_filter(queryset, name, value):
 
 
 class CoverFilterSet(TimestampMixin, BaseFilterSet):
-
     project = ProjectFilter(queryset=Project.objects.all(), distinct=False)
     # NOTE(stephenfin): We disable the select-based HTML widgets for these
     # filters as the resulting query is _huge_
@@ -205,7 +193,6 @@ class CoverFilterSet(TimestampMixin, BaseFilterSet):
 
 
 class PatchFilterSet(TimestampMixin, BaseFilterSet):
-
     project = ProjectFilter(queryset=Project.objects.all(), distinct=False)
     # NOTE(stephenfin): We disable the select-based HTML widgets for these
     # filters as the resulting query is _huge_
@@ -242,7 +229,6 @@ class PatchFilterSet(TimestampMixin, BaseFilterSet):
 
 
 class CheckFilterSet(TimestampMixin, BaseFilterSet):
-
     user = UserFilter(queryset=User.objects.all(), distinct=False)
 
     class Meta:
@@ -251,7 +237,6 @@ class CheckFilterSet(TimestampMixin, BaseFilterSet):
 
 
 class EventFilterSet(TimestampMixin, BaseFilterSet):
-
     # NOTE(stephenfin): We disable the select-based HTML widgets for these
     # filters as the resulting query is _huge_
     # TODO(stephenfin): We should really use an AJAX widget of some form here
@@ -285,7 +270,6 @@ class EventFilterSet(TimestampMixin, BaseFilterSet):
 
 
 class BundleFilterSet(BaseFilterSet):
-
     project = ProjectFilter(queryset=Project.objects.all(), distinct=False)
     owner = UserFilter(queryset=User.objects.all(), distinct=False)
 
index a08c126146047261055602599774abc3192b43ec..443c3822689fe08928f5834a948c57d1c688e8e8 100644 (file)
@@ -77,7 +77,6 @@ class PatchConflict(APIException):
 
 
 class PatchListSerializer(BaseHyperlinkedModelSerializer):
-
     web_url = SerializerMethodField()
     project = ProjectSerializer(read_only=True)
     state = StateField()
@@ -209,7 +208,6 @@ class PatchListSerializer(BaseHyperlinkedModelSerializer):
 
 
 class PatchDetailSerializer(PatchListSerializer):
-
     headers = SerializerMethodField()
     prefixes = SerializerMethodField()
 
index c806c0dd640823a2c7dad4a73c5b8f1488489f88..fde60da14d2632e6a4ff106f6b3e713182b14b57 100644 (file)
@@ -13,7 +13,6 @@ from patchwork.models import Person
 
 
 class PersonSerializer(HyperlinkedModelSerializer):
-
     user = UserSerializer(read_only=True)
 
     class Meta:
@@ -26,7 +25,6 @@ class PersonSerializer(HyperlinkedModelSerializer):
 
 
 class PersonMixin(object):
-
     permission_classes = (IsAuthenticated,)
     serializer_class = PersonSerializer
 
index 085dafd0c12f44c0d57e7d00a8997ab97fad80b6..2f0b47844bc4372926ba9c7c18ebcc20da84f600 100644 (file)
@@ -15,7 +15,6 @@ from patchwork.models import Project
 
 
 class ProjectSerializer(BaseHyperlinkedModelSerializer):
-
     link_name = CharField(max_length=255, source='linkname', read_only=True)
     list_id = CharField(max_length=255, source='listid', read_only=True)
     list_email = CharField(max_length=200, source='listemail', read_only=True)
@@ -63,7 +62,6 @@ class ProjectSerializer(BaseHyperlinkedModelSerializer):
 
 
 class ProjectMixin(object):
-
     permission_classes = (PatchworkPermission,)
     serializer_class = ProjectSerializer
 
index 32f0e30f1dd815226840c59bca5fefc91be39412..b88ed1f5f38a922170b40ff0086436e5847e8ac8 100644 (file)
@@ -18,7 +18,6 @@ from patchwork.models import Series
 
 
 class SeriesSerializer(BaseHyperlinkedModelSerializer):
-
     web_url = SerializerMethodField()
     project = ProjectSerializer(read_only=True)
     submitter = PersonSerializer(read_only=True)
@@ -71,7 +70,6 @@ class SeriesSerializer(BaseHyperlinkedModelSerializer):
 
 
 class SeriesMixin(object):
-
     permission_classes = (PatchworkPermission,)
     serializer_class = SeriesSerializer
 
index 980ad305362b45ed4265763e3ba0bac05d0950db..c00ce919993de396fd16fd22ac34f8b9cc1ac1fa 100644 (file)
@@ -83,7 +83,6 @@ class UserDetailSerializer(UserListSerializer):
 
 
 class UserMixin(object):
-
     queryset = User.objects.all()
     permission_classes = (permissions.IsAuthenticated, IsOwnerOrReadOnly)
 
index 7b5abc55619594fe8937badc55a919dd3272f74d..9831b6f46a5b68d4fee22514998351c3762dce08 100644 (file)
@@ -7,7 +7,6 @@ from django.apps import AppConfig
 
 
 class PatchworkAppConfig(AppConfig):
-
     name = 'patchwork'
     verbose_name = 'Patchwork'
 
index d5e5d5e79f8e0a65ef3fe71640a64c954c312c3f..99aad8c30f109ac7b2fed3fc3a456154d6a66799 100644 (file)
@@ -349,7 +349,7 @@ class ArchiveFilter(Filter):
     def key(self, key):
         self.archive_state = False
         self.applied = True
-        for (k, v) in self.param_map.items():
+        for k, v in self.param_map.items():
             if key == v:
                 self.archive_state = k
         if self.archive_state is None:
@@ -559,7 +559,7 @@ class Filters:
     def querystring(self, remove=None):
         params = self.params
 
-        for (k, v) in self.values.items():
+        for k, v in self.values.items():
             if k not in params:
                 params[k] = v
 
index f5596aa94002a223b69fd0902e5da6ac39a952a5..e7d1ad2770d0799323b1199dfa6326364ddc54ad 100644 (file)
@@ -137,7 +137,6 @@ class PatchForm(forms.ModelForm):
 
 
 class OptionalModelChoiceField(forms.ModelChoiceField):
-
     no_change_choice = ('*', 'no change')
     to_field_name = None
 
@@ -176,7 +175,6 @@ class OptionalBooleanField(forms.TypedChoiceField):
 
 
 class MultiplePatchForm(forms.Form):
-
     action = 'update'
     archived = OptionalBooleanField(
         choices=[
index 71a9c5805273ed5dae155aef5869ef9916d88054..225755363ce237e999f17b58040d58c2d715d085 100644 (file)
@@ -17,7 +17,7 @@ class Command(BaseCommand):
 
     def handle(self, *args, **kwargs):
         errors = send_notifications()
-        for (recipient, error) in errors:
+        for recipient, error in errors:
             self.stderr.write(
                 "Failed sending to %s: %s" % (recipient.email, error)
             )
index faa946643d624e1d8bb90a02a1701e4b54692d0e..c8dc9d211188ba5506c059d2ed4952b6218593dc 100644 (file)
@@ -8,7 +8,6 @@ import patchwork.models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         migrations.swappable_dependency(settings.AUTH_USER_MODEL),
     ]
index a8bcca37fb60ed15255ef477ad52b29dcb298cec..2fa8d6ba739c1a138153087715a137ae76be582f 100644 (file)
@@ -10,7 +10,6 @@ import patchwork.models
 
 
 class Migration(migrations.Migration):
-
     replaces = [
         ('patchwork', '0001_initial'),
         ('patchwork', '0002_fix_patch_state_default_values'),
index e42f622b17182b9fb001478a4ed29bf0302c0400..8e33e17e917afed4cbc7f763359702d53e86af17 100644 (file)
@@ -3,7 +3,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0001_initial'),
     ]
index 8c0df74cd302053082e29488997f77f403cc97bd..d2858affaf74a01248e7d96e12923756c7b4f54e 100644 (file)
@@ -6,7 +6,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         migrations.swappable_dependency(settings.AUTH_USER_MODEL),
         ('patchwork', '0002_fix_patch_state_default_values'),
index 97967c120895b07f003a4d3b09658503b771cc72..a6a6e437137a891bcfc295cf09167104049983c8 100644 (file)
@@ -4,7 +4,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         migrations.swappable_dependency(settings.AUTH_USER_MODEL),
         ('patchwork', '0003_add_check_model'),
index 2406820f69c3da879ef5a646e7654dc87e425190..246e9c0dfc9e1f60e09af014a7276a213f245cf4 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0004_add_delegation_rule_model'),
     ]
index ed63424da5609528a25a6a0367d54d0b2ab746e6..faac11a23b7a0632dff29e09038fe3f60e373421 100644 (file)
@@ -3,7 +3,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0005_unselectable_maintainer_projects'),
     ]
index 7c4947566e33fe818d18598755ffe7f33d4bfff5..89d080cbfc89569d9a5348697894138b1a714cac 100644 (file)
@@ -95,7 +95,6 @@ def recreate_comments(apps, schema_editor):
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0006_add_patch_diff'),
     ]
index 05be9c76e9abd052ff69344acaa1796255a3f346..a322e035881bbdf993e8d10b43c19246b2a567ec 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0007_move_comment_content_to_patch_content'),
     ]
index 5e0753dcac76d58de48bb7bc7049089975d7b85e..6d161990929126ca336d43f7b3157ca15353b0bd 100644 (file)
@@ -6,7 +6,6 @@ import patchwork.models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0008_add_email_mixin'),
     ]
index 3b80233626d8bd1d400925f4268d6419a686713a..32282285bb23a2bec9685a002745b5fba8198927 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0009_add_submission_model'),
     ]
index 19a4e00c64f1a0e73cebf813899233750dd5855f..070898765c48a6881bd51babf0bb188ba165b7a2 100644 (file)
@@ -3,7 +3,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0010_migrate_data_from_submission_to_patch'),
     ]
index 76c7d5d5563d73de02fa4cea58aeadc3523a3233..09e5f0cd15f394423871901d38e9ed928f3e6865 100644 (file)
@@ -3,7 +3,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0011_remove_temp_fields'),
     ]
index 3536adf32067de5ead8d20036fadaec3daef0377..eb54571bf5ef64244b5922b60043b2e5ab06078a 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0012_add_coverletter_model'),
     ]
index a5b02a5a77c4e7858f1ded2804c5f1b566402229..40da9d1ef47f3261a5d024c49d1dba4f47151dc2 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0013_slug_check_context'),
     ]
index 3325aa57e0e37156eeb90dbd5b787b6412b6d9d7..0c60698a589c7add4882a30744861fdbcf0998ee 100644 (file)
@@ -3,7 +3,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0014_remove_userprofile_primary_project'),
     ]
index 691c4c5a00e5b18082a4cc820c1decdbc14edd86..d9bbc0ce3698ecf22897fc2f2a57c970c0dbe793 100644 (file)
@@ -28,7 +28,6 @@ def reverse(apps, schema_editor):
 
 
 class Migration(migrations.Migration):
-
     # This is necessary due to a mistake made when writing the migration.
     # PostgreSQL does not allow mixing of schema and data migrations within the
     # same transaction. Disabling transactions ensures this doesn't happen.
index de9bb143db4a724e8bdae846ba381ce29f25d408..59773503b5b6dbbfb68a35ddb80cba007172c44b 100644 (file)
@@ -4,7 +4,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0016_series_project'),
     ]
index e51361013c52c75b8b8de4547c5e977451338395..0a8a984159c8a57f65627e4ae1b74c40b88e2120 100644 (file)
@@ -6,7 +6,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         migrations.swappable_dependency(settings.AUTH_USER_MODEL),
         ('patchwork', '0017_improved_delegation_rule_docs'),
index c88c9dea1315ce77cb8ce7d8f07623f471dec89b..ee32bb78006bf6cd44924893a03e151d36b94a86 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0018_add_event_model'),
     ]
index d16a6911c8dae7ccdf315e82c641a1926c9cc34d..10ce3b7870eeb3963417da0113f5f48357269cf6 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0019_userprofile_show_ids'),
     ]
index 90bc10ddbe546acdfe8ff9378b5ac496b2ac3308..d3512df0baf461aee7307bc5c1c2ca97d3c5c73f 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0020_tag_show_column'),
     ]
index 6f6e07a0d36841221793f1e98c058a487c9e321d..ce9ebd4579ef186279ce8f4d7f51e34fa090e411 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0021_django_1_10_fixes'),
     ]
index be9213c8794f07e02fef052938763f9505031526..50a70c3b17037f1dd00de8e3b21d01288ad6d39e 100644 (file)
@@ -4,7 +4,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0022_add_subject_match_to_project'),
     ]
index ca7da022de07a1fded3eaee90bd05f93a95f8d2a..d2978de1f22314ec8ad51cbf5b9bcbdb41e4727b 100644 (file)
@@ -4,7 +4,6 @@ import patchwork.models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0024_patch_patch_project'),
     ]
index 3c649d9df655987768205306dbb56ef0a5e3e42b..af9455cd9eed029afeca9f0326d84fad569d7484 100644 (file)
@@ -4,7 +4,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0025_add_regex_validators'),
     ]
index 4f6815464410e21e75ab5a6d185b4d3ec03c58bb..9072b47dba4371bb0ea0b57fab64df94239a1c6c 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0026_add_user_bundles_backref'),
     ]
index fbb4d7fa33dbc7b21c0b575b23ae5c83190210db..8db08aafa8627c420b6dd25e79006ff7a868d4ea 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0027_remove_series_ordering'),
     ]
index bd84e27a3ed97fecda59d4ccfc042c8e0a8bdfab..c48acb856bec79cf3a4bf1150e9a1df01fbb204f 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0028_add_comment_date_index'),
     ]
index 05bd642add5684f583c713850a99855f5fe7fa70..2f6eab6d6f99a5fa6c5436a28e18697c9fb03c9f 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0029_add_list_covering_index'),
     ]
index 585b00e6c13ee9d02274c0f04b3291ccd979320f..66e6b778599cbfe9f167becb5e0105135c5d5037 100644 (file)
@@ -3,7 +3,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0030_add_submission_covering_index'),
     ]
index 1cc809cb7a2621fd47c2c853c9955cc911a9e3b1..1307e43184344bc1fe21ab31116e2108a5cff502 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0031_add_patch_series_fields'),
     ]
index 203025894bd7f9ebcc47af3b9377561d4b64f7ae..b5b22845634e56cc27fd1b62e2fb5ac9acaa0fab 100644 (file)
@@ -3,7 +3,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0032_migrate_data_from_series_patch_to_patch'),
     ]
index 54dbcb5fa836561ac9bf5baee1d2c43afaa7e433..7e569e1eb48ca866f2344b5e56ae51c5c87a7f0b 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0033_remove_patch_series_model'),
     ]
index b9985b951f0ecf660b910bdd27c031981304c8d8..005e5a4eecb98a2b754ad0f2b369721a628a8ce1 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0034_project_list_archive_url'),
     ]
index 7bfda6996d87c43d8060584e7297b96b5a03926c..bf15c7abc1b306f1a5c9c90f52524afb5b9b321e 100644 (file)
@@ -2,7 +2,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0035_project_list_archive_url_format'),
     ]
index 1ce71e9c8b88b22cb5a368d50527f918b592f619..31c9c384ea26843250c56bd9f8c97df9782e8596 100644 (file)
@@ -6,7 +6,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         migrations.swappable_dependency(settings.AUTH_USER_MODEL),
         ('patchwork', '0036_project_commit_url_format'),
index 6355180b7a369ff16b3e598df64cfc6e12789579..419379c4fcb1cb1eed1499199798217530bbe800 100644 (file)
@@ -25,7 +25,6 @@ def validate_uniqueness(apps, schema_editor):
 
 
 def populate_slug_field(apps, schema_editor):
-
     State = apps.get_model('patchwork', 'State')
 
     with transaction.atomic():
@@ -35,7 +34,6 @@ def populate_slug_field(apps, schema_editor):
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0037_event_actor'),
     ]
index 3a101728cfcb3826ac166be14cde836c6d5fbbc8..545e21f20fde0f3942e172fe93ec589c79042419 100644 (file)
@@ -70,7 +70,6 @@ def delete_duplicate_series(apps, schema_editor):
 
 
 class Migration(migrations.Migration):
-
     dependencies = [('patchwork', '0038_state_slug')]
 
     operations = [
index fb0812b8e2ce55fa28a7c0168b6ddf1842328a63..3f6c30ceb4b8e730ec03e3f737c070f4dfb27cf2 100644 (file)
@@ -3,7 +3,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0039_unique_series_references'),
     ]
index 69a669f3b8ccce68809b5d4c721d0668874d8d28..09098c839acddc920feec7b48e2302ce3d1f46fb 100644 (file)
@@ -16,7 +16,6 @@ import patchwork.models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         migrations.swappable_dependency(settings.AUTH_USER_MODEL),
         ('patchwork', '0040_add_related_patches'),
index e785e17b1013845dcc13aa291fa1fc2908c7cbd8..d8cffd6a0df13cffcab668791aff06f0f0300256 100644 (file)
@@ -32,7 +32,6 @@ def delete_coverletter_comments(apps, schema_editor):
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0041_python3'),
     ]
index 23a4dbfb3d0deae6d3078908453fb52692d32f3d..d0e0374228a8dfd05c2d46f9010117376fe1716d 100644 (file)
@@ -74,7 +74,6 @@ def migrate_data(apps, schema_editor):
 
 
 class Migration(migrations.Migration):
-
     atomic = False
 
     dependencies = [
index d429bd56d9a67d6c00d55a214be8faea05f8e07b..f404592df8d0b4c8dad23e4bc9b163d430b1a271 100644 (file)
@@ -6,7 +6,6 @@ import re
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0043_merge_patch_submission'),
     ]
index 22887c337ccfbc848970af8ee5062b72adf61d75..0227452426ec26e2f2e81047c06be7a0bd51e0e3 100644 (file)
@@ -4,7 +4,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0044_add_project_linkname_validation'),
     ]
index db198bd48cf8eb1b2308998aadf3172a22a74f16..a3129bcfe5e3be0a5ac5ed9d84d39d2904bdf114 100644 (file)
@@ -3,7 +3,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('patchwork', '0045_addressed_fields'),
     ]
index 20ec9f06cfb4318e4322f04e5cafcf8577fe4736..e828c955f741088aac48a2c4cbc9df2cae01eff8 100644 (file)
@@ -477,7 +477,6 @@ class Cover(SubmissionMixin):
 
 
 class Patch(SubmissionMixin):
-
     diff = models.TextField(null=True, blank=True)
     commit_ref = models.CharField(max_length=255, null=True, blank=True)
     pull_url = models.CharField(max_length=255, null=True, blank=True)
@@ -722,7 +721,6 @@ class Patch(SubmissionMixin):
 
 
 class CoverComment(EmailMixin, models.Model):
-
     cover = models.ForeignKey(
         Cover,
         related_name='comments',
@@ -772,7 +770,6 @@ class CoverComment(EmailMixin, models.Model):
 
 
 class PatchComment(EmailMixin, models.Model):
-
     patch = models.ForeignKey(
         Patch,
         related_name='comments',
index b0e4f702785d4cd7119b7366b45c41fe13262129..50d047434ed0d6eaa59a5cf2477d571e0c317840 100644 (file)
@@ -43,7 +43,7 @@ def send_notifications():
 
     errors = []
 
-    for (recipient, notifications) in groups:
+    for recipient, notifications in groups:
         notifications = list(notifications)
 
         if recipient.id not in qs2 or qs2[recipient.id] < len(notifications):
index c0dc881887ed56abe5196c1ff60d53d0ddb16975..570851799f7bfee45e260e95519198fa4b6835a6 100644 (file)
@@ -22,7 +22,6 @@ ADJACENT_PAGES = 1
 
 class Paginator(paginator.Paginator):
     def __init__(self, request, objects):
-
         items_per_page = settings.DEFAULT_ITEMS_PER_PAGE
 
         if request.user.is_authenticated:
index 562c1c7c9e1eaedd6f60a737f9792123c663520a..e9104ca87290140598fed62bb84cd8611c8b535d 100644 (file)
@@ -68,7 +68,6 @@ class DuplicateMailError(Exception):
 
 
 class DuplicateSeriesError(Exception):
-
     pass
 
 
@@ -118,7 +117,7 @@ def sanitise_header(header_contents, header_name=None):
 
         new_value = []
 
-        for (part, _) in value:
+        for part, _ in value:
             # We have random bytes that aren't properly coded.
             # If we had a coding hint, it failed to help.
 
index 537abdfc20bb575c0071ba1c1ae001338c1a24d2..8e31080b1caa9365a7d8cb14d693ae8fdd444085 100644 (file)
@@ -242,7 +242,6 @@ def create_series_created_event(sender, instance, created, raw, **kwargs):
 
 @receiver(pre_save, sender=Patch)
 def create_series_completed_event(sender, instance, raw, **kwargs):
-
     # NOTE(stephenfin): It's actually possible for this event to be fired
     # multiple times for a given series. To trigger this case, you would need
     # to send an additional patch to already exisiting series. This pattern
index ad920de29e249c93acd64c73ae24ba0c57effce2..5d07c9bedc3a34e16c7c35e4bc6b9208d08ebf9b 100644 (file)
@@ -23,7 +23,7 @@ class ListURLNode(template.defaulttags.URLNode):
     def __init__(self, kwargs):
         super(ListURLNode, self).__init__(None, [], {}, False)
         self.params = {}
-        for (k, v) in kwargs.items():
+        for k, v in kwargs.items():
             if k in list_params:
                 self.params[k] = v
 
@@ -53,7 +53,7 @@ class ListURLNode(template.defaulttags.URLNode):
         except (TypeError, template.VariableDoesNotExist):
             pass
 
-        for (k, v) in self.params.items():
+        for k, v in self.params.items():
             params[smart_str(k, 'ascii')] = v.resolve(context)
 
         if not params:
index f49444aea09abd09aecc4989a0f74d24be2ed645..acf80a1ec5f8aea7af63c00c87f67bae262d2d2f 100644 (file)
@@ -16,7 +16,6 @@ register = template.Library()
 
 @register.filter
 def personify(person, project):
-
     if person.name:
         linktext = escape(person.name)
     else:
index 0132d17ba3b82426d72009ec3c0c4964dc96ee88..64773e5ab99754d2c9d8779ae9ecaee3c815d1f6 100644 (file)
@@ -72,7 +72,7 @@ def patchsyntax(patch):
 def commentsyntax(submission):
     content = escape(submission.content)
 
-    for (r, cls) in _comment_span_res:
+    for r, cls in _comment_span_res:
         content = r.sub(lambda x: _span % (cls, x.group(0)), content)
 
     return mark_safe(content)
index c3b03a8d9d825bf3273e82bae2c2aba45437105f..bf88ca926d39e19b8588897f5731da59d8545338 100644 (file)
@@ -70,7 +70,6 @@ def store_samples(filename):
             def client_wrapper(
                 orig_func, path, data=None, *orig_args, **orig_kwargs
             ):
-
                 req_filename = filename + '-req.json'
                 resp_filename = filename + '-resp.json'
 
index 1278137bfa1f2d7a9b96df7a790a0521c39f400c..8001a9bba8b9749eee075ed17e375bd0ac1c5145 100644 (file)
@@ -132,7 +132,6 @@ class PatchTest(TestCase):
 
 
 class InlinePatchTest(PatchTest):
-
     orig_content = 'Test for attached patch'
     orig_diff = read_patch('0001-add-line.patch')
 
@@ -148,7 +147,6 @@ class InlinePatchTest(PatchTest):
 
 
 class AttachmentPatchTest(InlinePatchTest):
-
     orig_content = 'Test for attached patch'
     content_subtype = 'x-patch'
 
@@ -164,12 +162,10 @@ class AttachmentPatchTest(InlinePatchTest):
 
 
 class AttachmentXDiffPatchTest(AttachmentPatchTest):
-
     content_subtype = 'x-diff'
 
 
 class UTF8InlinePatchTest(InlinePatchTest):
-
     orig_diff = read_patch('0002-utf-8.patch', 'utf-8')
 
     def setUp(self):
@@ -193,7 +189,6 @@ class NoCharsetInlinePatchTest(InlinePatchTest):
 
 
 class SignatureCommentTest(InlinePatchTest):
-
     orig_content = 'Test comment\nmore comment'
 
     def setUp(self):
@@ -212,7 +207,6 @@ class UpdateSigCommentTest(SignatureCommentTest):
 
 
 class ListFooterTest(InlinePatchTest):
-
     orig_content = 'Test comment\nmore comment'
 
     def setUp(self):
@@ -231,7 +225,6 @@ class ListFooterTest(InlinePatchTest):
 
 
 class DiffWordInCommentTest(InlinePatchTest):
-
     orig_content = (
         'Lines can start with words beginning in "diff"\n'
         + 'difficult\nDifferent'
@@ -884,7 +877,6 @@ class CommentParseTest(TestCase):
 
 
 class DelegateRequestTest(TestCase):
-
     patch_filename = '0001-add-line.patch'
     msgid = '<1@example.com>'
     invalid_delegate_email = "nobody"
@@ -925,7 +917,6 @@ class DelegateRequestTest(TestCase):
 
 
 class CommentActionRequiredTest(TestCase):
-
     fixtures = ['default_tags']
 
     def setUp(self):
@@ -988,7 +979,6 @@ class CommentActionRequiredTest(TestCase):
 
 
 class InitialPatchStateTest(TestCase):
-
     patch_filename = '0001-add-line.patch'
     msgid = '<1@example.com>'
     invalid_state_name = "Nonexistent Test State"
@@ -1044,7 +1034,6 @@ class InitialPatchStateTest(TestCase):
 
 
 class ParseInitialTagsTest(PatchTest):
-
     fixtures = ['default_tags']
     patch_filename = '0001-add-line.patch'
     orig_content = (
index 046c3e0bbd13fe9aabe61eb5033072c94a882f34..a4ea02efa8efe6fbb689bdbb0f3985f789f4f81a 100644 (file)
@@ -14,7 +14,6 @@ from patchwork.tests.utils import create_patch_comment
 
 
 class ExtractTagsTest(TestCase):
-
     fixtures = ['default_tags']
     email = 'test@example.com'
     name_email = 'test name <' + email + '>'
@@ -72,7 +71,6 @@ class ExtractTagsTest(TestCase):
 
 
 class PatchTagsTest(TransactionTestCase):
-
     fixtures = ['default_tags']
     ACK = 1
     REVIEW = 2
index dad2107b9c61ccd20d61573780d7c718f1ce581f..3ea9600e846d73c56a0b43a2435fd850633efd1e 100644 (file)
@@ -138,7 +138,6 @@ class XMLRPCModelTestMixin(object):
 
 
 class XMLRPCFilterModelTestMixin(XMLRPCModelTestMixin):
-
     # override these tests due to the way you pass in filters
     def test_list_max_count(self):
         objs = self.create_multiple(5)
index 57340fa432ab3603ed1ef6db537e4268bdb99176..dd22bcfbf23dcc7dfccfef1260f2824b70aedb30 100644 (file)
@@ -756,7 +756,7 @@ class BundleInitialOrderTest(BundleTestBase):
         # BundlePatches should be sorted by .order by default
         bps = BundlePatch.objects.filter(bundle=bundle)
 
-        for (bp, p) in zip(bps, expected_order):
+        for bp, p in zip(bps, expected_order):
             self.assertEqual(bp.patch.pk, p.pk)
 
         bundle.delete()
index 682978c5350c784a329f030d70fea1a84472bcbb..46247c162401f82fabeed31ec82bca29b532bbae 100644 (file)
@@ -38,7 +38,6 @@ class EmptyPatchListTest(TestCase):
 
 
 class PatchListOrderingTest(TestCase):
-
     patchmeta = [
         (
             'AlCMyjOsx',
@@ -382,7 +381,6 @@ class PatchViewTest(TestCase):
 
 
 class PatchUpdateTest(TestCase):
-
     properties_form_id = 'patchform-properties'
 
     def setUp(self):
index c3199ffd0123bd29677aa326c3e2054f13640417..cdad279d4090ad730582b4bb350ce5a84a1c2c1b 100644 (file)
@@ -23,7 +23,7 @@ bundle_actions = ['create', 'add', 'remove']
 def get_patch_ids(d, prefix='patch_id'):
     ids = []
 
-    for (k, v) in d.items():
+    for k, v in d.items():
         a = k.split(':')
         if len(a) != 2:
             continue
@@ -180,7 +180,6 @@ def generic_list(
     patches=None,
     editable_order=False,
 ):
-
     if not filter_settings:
         filter_settings = []
 
@@ -266,7 +265,7 @@ def generic_list(
         if errors:
             context['errors'] = errors
 
-    for (filterclass, setting) in filter_settings:
+    for filterclass, setting in filter_settings:
         if isinstance(setting, dict):
             context['filters'].set_status(filterclass, **setting)
         elif isinstance(setting, list):
index 4e023867ef90447baee1dc27baf0d22f315504bd..d728d500381dfcc12f21c28753ee0c675e11bc4f 100644 (file)
@@ -14,7 +14,6 @@ from patchwork.views import user
 
 
 def confirm(request, key):
-
     views = {
         'userperson': user.link_confirm,
         'registration': user.register_confirm,
index f134275d9837492af035b7d06a0be7b30598a764..8dbd749b5ab481fea656112fe1b5e1afe1fc1c14 100644 (file)
@@ -25,7 +25,6 @@ from patchwork.views.utils import patch_to_mbox
 
 
 class PatchworkXMLRPCDispatcher(SimpleXMLRPCDispatcher, XMLRPCDocGenerator):
-
     server_name = 'Patchwork XML-RPC API'
     server_title = 'Patchwork XML-RPC API v1 Documentation'
 
@@ -730,7 +729,7 @@ def patch_set(user, patch_id, params):
     if not patch.is_editable(user):
         raise Exception('No permissions to edit this patch')
 
-    for (k, v) in params.items():
+    for k, v in params.items():
         if k not in ok_params:
             continue