clk: versaclock: Use IS_ERR check before dereference

In versaclock_probe vc5->pin_xin may be an error pointer so need to
check with IS_ERR before attempting to dereference it.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

diff --git a/drivers/clk/clk_versaclock.c b/drivers/clk/clk_versaclock.c
index 790ea4dbe82e9aca3c6572b0e56e1383eff2ccac..19a787eaf0c564e993c4479976a22ac781ad4473 100644 (file)
--- a/drivers/clk/clk_versaclock.c
+++ b/drivers/clk/clk_versaclock.c
@@ -904,12 +904,12 @@ int versaclock_probe(struct udevice *dev)
        if (IS_ERR(mux_name))
                return PTR_ERR(mux_name);
 
-       clk_register(&vc5->clk_mux, "versaclock-mux", mux_name, vc5->pin_xin->dev->name);
-
-       if (!IS_ERR(vc5->pin_xin))
+       if (!IS_ERR(vc5->pin_xin)) {
+               clk_register(&vc5->clk_mux, "versaclock-mux", mux_name, vc5->pin_xin->dev->name);
                vc5_mux_set_parent(&vc5->clk_mux, 1);
-       else
+       } else {
                vc5_mux_set_parent(&vc5->clk_mux, 0);
+       }
 
        /* Configure Optional Loading Capacitance for external XTAL */
        if (!(vc5->chip_info->flags & VC5_HAS_INTERNAL_XTAL)) {