]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
btrfs: fix referenced/exclusive check in squota_check_parent_usage()
authorBoris Burkov <boris@bur.io>
Wed, 11 Feb 2026 19:01:25 +0000 (11:01 -0800)
committerDavid Sterba <dsterba@suse.com>
Thu, 26 Feb 2026 14:03:27 +0000 (15:03 +0100)
We compared rfer_cmpr against excl_cmpr_sum instead of rfer_cmpr_sum
which is confusing.

I expect that
rfer_cmpr == excl_cmpr in squota, but it is much better to be consistent
in case of any surprises or bugs.

Reported-by: Chris Mason <clm@meta.com>
Link: https://lore.kernel.org/linux-btrfs/cover.1764796022.git.boris@bur.io/T/#mccb231643ffd290b44a010d4419474d280be5537
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Boris Burkov <boris@bur.io>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/qgroup.c

index 38adadb936dc247a9273f65d3ef5e457296d606b..19edd25ff5d1ae020e5eae4127a11621ded97af3 100644 (file)
@@ -370,7 +370,7 @@ static bool squota_check_parent_usage(struct btrfs_fs_info *fs_info, struct btrf
                nr_members++;
        }
        mismatch = (parent->excl != excl_sum || parent->rfer != rfer_sum ||
-                   parent->excl_cmpr != excl_cmpr_sum || parent->rfer_cmpr != excl_cmpr_sum);
+                   parent->excl_cmpr != excl_cmpr_sum || parent->rfer_cmpr != rfer_cmpr_sum);
 
        WARN(mismatch,
             "parent squota qgroup %hu/%llu has mismatched usage from its %d members. "