]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: hda/conexant - Use cached pin control for Node 0x1d on HP EliteOne 1000 G2
authorVasiliy Kovalev <kovalev@altlinux.org>
Wed, 16 Oct 2024 08:07:13 +0000 (11:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Oct 2024 13:39:30 +0000 (15:39 +0200)
commit 164cd0e077a18d6208523c82b102c98c77fdd51f upstream.

The cached version avoids redundant commands to the codec, improving
stability and reducing unnecessary operations. This change ensures
better power management and reliable restoration of pin configurations,
especially after hibernation (S4) and other power transitions.

Fixes: 9988844c457f ("ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2")
Suggested-by: Kai-Heng Feng <kaihengf@nvidia.com>
Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
Link: https://patch.msgid.link/20241016080713.46801-1-kovalev@altlinux.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/hda/patch_conexant.c

index 199af020555c90cbfe14a96a26408167433c2bd0..51d97de74cad13a6ae471765cde261ff32903076 100644 (file)
@@ -261,7 +261,7 @@ static void cxt_fixup_update_pinctl(struct hda_codec *codec,
                 * This is the value stored in the codec register after
                 * the correct initialization of the previous windows boot.
                 */
-               snd_hda_set_pin_ctl(codec, 0x1d, AC_PINCTL_HP_EN);
+               snd_hda_set_pin_ctl_cache(codec, 0x1d, AC_PINCTL_HP_EN);
        }
 }