]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: venus: Fix uninitialized variable count being checked for zero
authorColin Ian King <colin.king@canonical.com>
Fri, 15 Jan 2021 10:11:26 +0000 (11:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 May 2025 05:41:21 +0000 (07:41 +0200)
commit c5b14df7a80acadbbd184808dc3f519fbb2ab96c upstream.

In the case where plat->codecs is NULL the variable count is uninitialized
but is being checked to see if it is 0. Fix this by initializing
count to 0.

Addresses-Coverity: ("Uninitialized scalar variable")

Fixes: e29929266be1 ("media: venus: Get codecs and capabilities from hfi platform")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/qcom/venus/hfi_parser.c

index c6be1564c876dff7c7f79e808124ac8c81da44f2..cb7645f88a46b086654a969b1cedf4280e1be7f9 100644 (file)
@@ -266,7 +266,7 @@ static int hfi_platform_parser(struct venus_core *core, struct venus_inst *inst)
 {
        const struct hfi_platform *plat;
        const struct hfi_plat_caps *caps = NULL;
-       u32 enc_codecs, dec_codecs, count;
+       u32 enc_codecs, dec_codecs, count = 0;
        unsigned int entries;
 
        if (inst)