Woops, forgot the second warn.

Also, differentiate the two log messages.

diff --git a/src/or/routerlist.c b/src/or/routerlist.c
index 392588cef45a4403cdcfb8df63acda66aba03047..a67703ca4b9abbf7579e61011292527c32d1cf1e 100644 (file)
--- a/src/or/routerlist.c
+++ b/src/or/routerlist.c
@@ -1576,10 +1576,10 @@ smartlist_choose_by_bandwidth_weights(smartlist_t *sl,
              rule == WEIGHT_FOR_MID ||
              rule == WEIGHT_FOR_DIR);
 
-  if (!sl || smartlist_len(sl) == 0) {
+  if (smartlist_len(sl) == 0) {
     log_info(LD_CIRC,
-             "Empty routerlist passed in to node selection for rule %d",
-             rule);
+             "Empty routerlist passed in to consensus weight node "
+             "selection for rule %d", rule);
     return NULL;
   }
 
@@ -1783,9 +1783,9 @@ smartlist_choose_by_bandwidth(smartlist_t *sl, bandwidth_weight_rule_t rule,
              rule == WEIGHT_FOR_EXIT ||
              rule == WEIGHT_FOR_GUARD);
 
-  if (!sl || smartlist_len(sl) == 0) {
-    log_warn(LD_CIRC,
-             "Empty routerlist passed in to node selection for rule %d",
+  if (smartlist_len(sl) == 0) {
+    log_info(LD_CIRC,
+             "Empty routerlist passed in to old node selection for rule %d",
              rule);
     return NULL;
   }