convert: add const to fix strchr() warnings

C23 versions of libc (like recent glibc) may provide generic versions of
strchr() that match constness between the input and return value. The
idea being that the compiler can detect when it implicitly converts a
const pointer into a non-const one (which then emits a warning).

There are a few cases here where the result pointer does not need to be
non-const at all, and we should mark it as such. That silences the
warning (and avoids any potential problems with trying to write via
those pointers).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/convert.c b/convert.c
index a34ec6ecdc057e1d5df6c53acced89e23dda2645..eae36c8a5936f4bfef4bdd519fa385b841c495bf 100644 (file)
--- a/convert.c
+++ b/convert.c
@@ -1168,7 +1168,8 @@ static int ident_to_worktree(const char *src, size_t len,
                             struct strbuf *buf, int ident)
 {
        struct object_id oid;
-       char *to_free = NULL, *dollar, *spc;
+       char *to_free = NULL;
+       const char *dollar, *spc;
        int cnt;
 
        if (!ident)