[2850] Make ZoneTableSegmentLocal::reset() throw NotImplemented exception

diff --git a/src/lib/datasrc/memory/zone_table_segment_local.cc b/src/lib/datasrc/memory/zone_table_segment_local.cc
index dbcb54f1a2be7d27037656f3ddb9c3864248d72a..7bafa1174c1ad1851757b21445329a9acd0bac26 100644 (file)
--- a/src/lib/datasrc/memory/zone_table_segment_local.cc
+++ b/src/lib/datasrc/memory/zone_table_segment_local.cc
@@ -41,7 +41,9 @@ void
 ZoneTableSegmentLocal::reset(MemorySegmentOpenMode,
                              isc::data::ConstElementPtr)
 {
-    // This method doesn't do anything in this implementation.
+    isc_throw(isc::NotImplemented,
+              "ZoneTableSegmentLocal::reset() is not implemented and "
+              "should not be used.");
 }
 
 // After more methods' definitions are added here, it would be a good

diff --git a/src/lib/datasrc/memory/zone_table_segment_local.h b/src/lib/datasrc/memory/zone_table_segment_local.h
index 6430d2a46833b769bc93225ee9ace303d811d08e..cbb3b27fb1359e531831f7d4e85eba261e29a492 100644 (file)
--- a/src/lib/datasrc/memory/zone_table_segment_local.h
+++ b/src/lib/datasrc/memory/zone_table_segment_local.h
@@ -61,9 +61,9 @@ public:
         return (true);
     }
 
-    /// \brief This method currently doesn't do anything.
+    /// \brief This method is not implemented.
     ///
-    /// \c mode and \c params args are currently ignored.
+    /// \throw isc::NotImplemented
     virtual void reset(MemorySegmentOpenMode mode,
                        isc::data::ConstElementPtr params);
 

diff --git a/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc b/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
index d8d5d06b74c2c453bfa15f6742535f9d6cb941bd..8afc1ac8b8f9a91b3ee1352e413892d129161ae4 100644 (file)
--- a/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
+++ b/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
@@ -52,10 +52,12 @@ TEST_F(ZoneTableSegmentTest, create) {
 }
 
 TEST_F(ZoneTableSegmentTest, reset) {
-    // reset() currently doesn't do anything in a local segment. But
-    // test the API.
-    ztable_segment_->reset(ZoneTableSegment::CREATE,
-                           Element::fromJSON("{}"));
+    // reset() should throw that it's not implemented so that any
+    // accidental calls are found out.
+    EXPECT_THROW({
+        ztable_segment_->reset(ZoneTableSegment::CREATE,
+                               Element::fromJSON("{}"));
+    }, isc::NotImplemented);
 }
 
 // Helper function to check const and non-const methods.