Fix a hard-to-trigger memory leak in log_credential status. Found by Coverity scan...

svn:r17484

diff --git a/ChangeLog b/ChangeLog
index b5438817b6f2229f5863a8a58f0c2dd49951ca46..25756ddcf4e81c2572360fd910340c481900279f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -34,6 +34,9 @@ Changes in version 0.2.1.8-alpha - 2008-??-??
     - Correct handling of possible malformed authority signing key
       certificates with internal signature types.  Fixes bug 880.
       Bugfix on 0.2.0.3-alpha.
+    - Fix a hard-to-trigger resource leak when logging credential status.
+      CID 349.
+    - 
 
   o Minor features:
     - Report the case where all signatures in a detached set are rejected

diff --git a/src/common/compat.c b/src/common/compat.c
index fcc57f60db5242482e745a27531fd4f92fdd34d5..9ce5885dc18593748de0e1a48d52030999d4e1e3 100644 (file)
--- a/src/common/compat.c
+++ b/src/common/compat.c
@@ -1049,17 +1049,17 @@ log_credential_status(void)
              strerror(errno));
     return -1;
   } else {
-    int i;
+    int i, retval = 0;
     char *strgid;
     char *s = NULL;
-    int formatting_error = 0;
     smartlist_t *elts = smartlist_create();
 
     for (i = 0; i<ngids; i++) {
       strgid = tor_malloc(11);
-      if (tor_snprintf(strgid, 11, "%u", (unsigned)sup_gids[i]) == -1) {
+      if (tor_snprintf(strgid, 11, "%u", (unsigned)sup_gids[i]) < 0) {
         log_warn(LD_GENERAL, "Error printing supplementary GIDs");
-        formatting_error = 1;
+        tor_free(strgid);
+        retval = -1;
         goto error;
       }
       smartlist_add(elts, strgid);
@@ -1077,8 +1077,7 @@ log_credential_status(void)
     });
     smartlist_free(elts);
 
-    if (formatting_error)
-      return -1;
+    return retval;
   }
 #endif