s4/rpc_server/dnsserver: cppcheck: Fix Uninitialized variable error.

source4/rpc_server/dnsserver/dcerpc_dnsserver.c:715: error: uninitvar: Uninitialized variable: answer_integer <--[cppcheck]

This error is benign and somewhat false because the code pointed to does
not run (due to a different check) if answer_integer is not actually
initialsed. It is easy to squash it though by just initialising the var.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c
index 841557814a0290d4fbc39ee41a950285f3f679d3..1bb46a58339a6343870cb1522124c24e651074f7 100644 (file)
--- a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c
+++ b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c
@@ -374,6 +374,7 @@ static WERROR dnsserver_query_server(struct dnsserver_state *dsstate,
        }
 
        is_integer = 0;
+       answer_integer = 0;
 
        if (strcasecmp(operation, "AddressAnswerLimit") == 0) {
                answer_integer = serverinfo->cAddressAnswerLimit;
@@ -834,7 +835,7 @@ static WERROR dnsserver_query_zone(struct dnsserver_state *dsstate,
                                        union DNSSRV_RPC_UNION *r)
 {
        uint8_t is_integer, is_addresses, is_string;
-       uint32_t answer_integer;
+       uint32_t answer_integer = 0;
        struct IP4_ARRAY *answer_iparray;
        struct DNS_ADDR_ARRAY *answer_addrarray;
        char *answer_string;